Fix Cray NHC spawning on job requeue. Previous logic would leave nodes
allocated to a requeued job as non-usable on job termination.

Specifically, each job has a "cleaning/cleaned" flag. Once a job
terminates, the cleaning flag is set, then after the job node health
check completes, the value gets set to cleaned. If the job is requeued,
on its second (or subsequent) termination, the select/cray plugin
is called to launch the NHC. The plugin sees the "cleaned" flag
already set, it then logs:
error: select_p_job_fini: Cleaned flag already set for job 1283858, this should never happen
and returns, never launching the NHC. Since the termination of the
job NHC triggers releasing job resources (CPUs, memory, and GRES),
those resources are never released for use by other jobs.

Bug 2384

_set_collectors() already has a run_in_daemon("slurmd") that
precludes this from being an issue.

route_p_split_hostlist was not thread-safe, and would cause
one of several segfaults depending on where in the initialization
code each thread was.

Bug 2495.

Was incorrectly displaying "(null)" even when loaded successfully.

Step GRES value changed from type "int" to "int64_t" to support larger
values.

Signed-off-by: Danny Auble <da@schedmd.com>

Bug 2507

Step GRES value changed from type "int" to "int64_t" to support larger
values. Previous logic could fail in step allocation values over 32-bits.
Other GRES values are 64-bit.

slurmstepd to close potential open ones.

It was pointed out the slurmd using acct_gather_energy/ipmi links to
freeipmi which could possibly open /dev/ipmi0 without the close on exec
flag set as root while launching a step leaving it open in the users app.

What this does is sets the flag on the first 256 to mitigate the concern.

Reported by Maksym Planeta.

Bug 2506

Previous logic tested whatever the job's partition pointer indicated
rather than the partition we are trying to run the job in. This bug
was introduced in Slurm version 15.08.5, Nov 16, 2015, commit
94f0e948
bug 2499

patch 2d5066e7

This fixes a bug introduced in commit 52fe3de1
in the event the fork() call fails in slurmstepd.

Insure that a job is completely launched before trying to suspend it.
Previous logic would start suspend logic early in the life of the
slurmstepd process, after it's listening socket was open but before
the tasks were launched. This defers the suspend logic until after
all prologs and setup completes and the tasks are launched. This is
important in the case of gang scheduling, in which newly launched
jobs can be immediately suspended.
bug 2494

Since the function is inlined the single definition let GCC build everything
properly, but debug builds (which disable inline) resulted in:
slurmstepd: [465.0]: symbol lookup error:
(trimmed path)/task_cgroup.so: undefined symbol: val_to_char
when running srun --cpu_bind=v.

task/affinity had this definition already, task/cgroup didn't.

Reported by valgrind running test7.2, but shouldn't cause any real problem

was also given.

a partition.

This also reverts most of commit fa331e30 as well as commit bd9fa830
which would try to set the pn_min_cpus every time a job was updated.
If a job didn't request node counts then they were hosed.

This commit takes away the magic which was screwing things up.  Now the
person gets what they asked for without magic changing things.

Bug 2302
Bug 2742
Bug 2478

erroneously.

Failure has never been observed, but initialize the used variable
  before calling the function so we don't re-use old data if the
  function returns an error.

Rename an improperly named variable in the logic scontrol uses to
  print node information ("total_used" was really "idle_cpus"), so
  the logic looks the same as that used in sinfo to determine node
  state.

Include warning for Cray simulation as reminder for developers to
change code as needed.

This whole process could probably be done better by keeping track of
old values and new values and only calling one function instead of a
pre and post function, but that can probably wait for future generations
of the code as it works now and is probably adequate for the time being.

Bug 2352

Consistantly use American English for
existant -> existent
assocation -> association

Correct some typos, and one grammatical mistake.

BurstBuffer/cray - Defer job cancellation or time limit while "pre-run"
    operation in progress to avoid inconsistent state due to multiple calls
    to job termination functions.
bug 2454

Otherwise call fclose(NULL) iff the ClusterName is not set and the
clustername file does not exist. Should not happen in production.

Coverity #67041.