Skip to content
Snippets Groups Projects

Refactor and fix check-code-style and pre-commit script

Merged Alexander Grund requested to merge fix-check-script into preview

The return value of style_check was reversed returning true for "no errors" while the script checks for true meaning "error found". Adjust that by direct return 0. Also replace use of backticks by $(...) as suggested by shellCheck.

Also refactor the pre-commit script where especially the docker command was so long it was hard to see what is being done, so put that into functions. Also add some output to see where things went wrong (the faulty code-style script was hard to find)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading