Correct code style checks/improve code style

doc.zih.tu-dresden.de/util/check-code-style.sh

@@ -46,20 +46,20 @@ function pattern_matches() {
   test_res_count=0
   if  [[ "${ext}" == "sh" ]]; then
     # If shell script is provided
-    if grep -qP "${pattern}" "$myfile"; then
+    if grep -qP "${pattern}" "${myfile}"; then
       echo -e "[WARNING] ${warning}"
       echo "[WARNING] This coding style was not used for following lines in file $(realpath "${myfile}"):"
-      grep -nP "${pattern}" "$myfile"
+      grep -nP "${pattern}" "${myfile}"
       echo ""
       return 0
     fi
   elif [[ "${ext}" == "md" ]]; then
     # If markdown file is provided
     # Check if the code snippet exists in the markdown file
-    if sed -n '/^```bash$/,/^```$/p' "$myfile" | grep -qv '```'; then
+    if sed -n '/^```bash$/,/^```$/p' "${myfile}" | grep -qv '```'; then
       # Extracting code snippet within ```bash ... ```
       local test_string
-      test_string=$(sed -n '/^```bash$/,/^```$/p' "$myfile" | grep -v '```')
+      test_string=$(sed -n '/^```bash$/,/^```$/p' "${myfile}" | grep -v '```')
 
       # Check the exit code of pattern match
       if echo "${test_string}" | grep -qP "${pattern}"; then
@@ -95,7 +95,7 @@ if [[ $# -eq 1 ]]; then
   ;;
   -a | --all)
     echo "Checking in all files."
-    files=$(find "$basedir" -name '*.md' -o -name '*.sh')
+    files=$(find "${basedir}" -name '*.md' -o -name '*.sh')
   ;;
   *)
     files="$1"
@@ -103,7 +103,7 @@ if [[ $# -eq 1 ]]; then
   esac
 elif [[ $# -eq 0 ]]; then
   echo "Search in git-changed files."
-  files=$(git diff --name-only "$(git merge-base HEAD "$branch")" | grep -e '.md$' -e '.sh$' || true)
+  files=$(git diff --name-only "$(git merge-base HEAD "${branch}")" | grep -e '.md$' -e '.sh$' || true)
 else
   usage
 fi
@@ -112,7 +112,7 @@ any_fails=false
 
 for file in ${files}; do
   # Skip the check of this current ($0) script.
-  if echo "${file}" | grep -qP "check-code-style.sh$"; then
+  if [[ "${file}" =~ check-code-style.sh$ ]]; then
     continue
   fi
 
@@ -133,11 +133,15 @@ for file in ${files}; do
   # Line length less than 100 char length
   file_ext="${file##*.}"
   if [[ "${file_ext}" == "sh" ]]; then
-    #echo "Checking for max line length..."
-    pattern='^.{100}.*$'
-    warning="Recommended maximum line length is 100 characters."
-    if pattern_matches "${file}" "${pattern}" "${warning}"; then
-      any_fails=true
+    if [[ "${file}" =~ grep-forbidden-patterns.sh$ ]]; then
+      : # skip
+    else
+      #echo "Checking for max line length..."
+      pattern='^.{100}.*$'
+      warning="Recommended maximum line length is 100 characters."
+      if pattern_matches "${file}" "${pattern}" "${warning}"; then
+        any_fails=true
+      fi
     fi
   fi