The slurm_get_auth_info() function returns an xmalloc'ed string
which few places were xfree'ing. The function in the past did
not xmalloc a value, but returned a pointer to a cached string.
When that was changed, the calls to the function were not all
changed, resulting in leaks if AuthInfo was defined in slurm.conf.

Any access to this would be out of range. ASAN reports this as a two-word
leak (due to allocaction[-2] and [-1] being used for xmalloc header info).

ASAN detected an issue with the uninitialized one_liner variable,
move all initialization to global variable definitions for simplicity.

Found by ASAN.

Presumably you're okay handling timeouts when calling slurm_cond_timedwait
otherwise you should have used slurm_cond_wait.

Bug 2829.

it.

deleted make it possible.

This reverts commit 7843e158.

Conflicts:
	NEWS

Recalculate a job's memory allocation after node reboot if job requests all
    of a node's memory and FastSchedule=0 is configurated. Intel KNL memory size
    can change on reboot with various MCDRAM modes.
bug 2822

Initially I wanted to record somehow the time a job has been in PD state
until it actually starts. To do so, I derived an eligible_time field which
was calculated as start_time - begin_time. This was not correct and a user
of the plugin reported that if the job remained a lot of time in PD state
the field underflowed. A more accurate approach would be calculating the
field as start_time - eligible_time (the actual Slurm eligible_time).
Since this field is not accessible within the log_record function which
receives a job_record struct as parameter, I've decided to just remove this
field from being logged.

Recalculate a job's memory allocation after node reboot if job requests all
    of a node's memory and FastSchedule=0 is configurated. Intel KNL memory size
    can change on reboot with various MCDRAM modes.
bug 2822

Prior logic was getting confused with NUMA containing no cores.
bug 2745

correct precompile directive to test for variable definition rather
than true value. Correction to commit 01b658a3

strlcpy ensures strings are terminated with \0 properly.

doesn't have a parent.

correct precompile directive to test for variable definition rather
than true value. Correction to commit 01b658a3

Make sure strings are NULL terminated.
Prolems reported by Coverity