No change in logic

bug 3399

bug 3099

Improve logic from commit 1f8e8c9f

This reverts commit e92b49d3.

No functional change.

Fill the entire buffer, snprintf will always terminate with \0.

instead of also in the backfill scheduler.

PATH_MAX is used in many other places within the source without these
definitions; while technically optional in POSIX1.2008 I have not
seen anywhere that does not set it, and if such a system exists
it'll be needed elsewhere and the build system should handle it.

Also, POSIX1.2008 states this must be at least 1024, not 256
as used here.

Avoid allocating resources to a job in the event that its run time
    plus boot time (if needed) extent into an advanced reservation.
Note that if resources have not yet been selected (e.g. determining
  availability of licenses or burst buffers with respect to advanced
  reservations) then assume a reboot will be required.
bug 3360

Bug 3405.

acct_policy_job_runnable_pre_select() calls assoc_mgr_set_qos_tres_cnt()
without tres READ_LOCK.

Note that existing code does not modify the tres structures, so this
cannot currently lead to a race condition.

Bug 3406.

Add function arguments in several places to trigger the inclusion
  of node reboot times in determining resource availability, but
  don't change the behaviour yet (just add reboot=false everywhere).
bug 3360

before checking it with scontrol show job. The test was failing for me
because the job hadn't started yet.

job_submit/cnode was previously removed by commit 63bc71ed.

Bug 3403.

Add BootTime configuration parameter to knl.conf file to optimize resource
    allocations with respect to required node reboots.
Add node_features_p_boot_time() to node_features plugin to optimize
    scheduling with respect to node reboots.
bug 3360

When a buffer packed failed due to invalid message version, a NULL
  pointer was returned, which later resulted in an assert failure.
  This adds a check for a NULL pointer and avoids the assert.

Bug 3257.

Make it easier to see the 17.02 changes as they are added in.

RPCs will switch to using bit_str_hex for serialization from bit_fmt,
but receivers still need to access this as a inx formatted array for now.
Collapse this into one macro rather than repeating a bunch of times.

Note that this would be better performing if consolidated into a single
function rather than using unpack_bit_str_hex then bitstr2inx to convert;
although this is a client-side function and less important than avoiding
performance and throughput issues within slurmctld.

pack_bit_fmt can exceed 0xfffe characters on large systems and thus
truncate leading to:
"error: Credential signature check: Credential data size mismatch"

Add warning to the pack_bit_fmt macro to highlight issue.

Bug 3257.

bug 3072

bug 3072

scancel modified to note that no jobs satisfy the filter options when the
    --verbose option is used along with one or more job filters (e.g. "--qos=").
bug 3072

scancel would treat a non-numeric argument as the name of jobs to be
    cancelled (a non-documented feature). Cancelling jobs by name now require
    the "--jobname=" command line argument.
bug 3072

Coverity was reporting possibly unterminated string