as reported when compiling with optimizations (-02). Initialize the
variables early since they were being initialized in their loops and
later checked for -1.

Technically couldn't have happened since for example, user_part_inx1
would only be set to -1 if max_backfill_job_per_user_part was set. And
user_part_inx is only checked later if max_backfill_job_per_user_part
is set.

Same thing for part_inx, max_backfill_job_per_part and user_inx,
max_backfill_job_per_user.

reported when compiling with optimizations (-O2). The compiler ignores
the (void) cast and reports the error.

reported when compiling with optimizations (-O2). field_id may be
uninitialized or the the value from the previous iteration in the while
loop. The only possible values of dataset_loc->type are:

typedef enum {
	PROFILE_FIELD_NOT_SET,
	PROFILE_FIELD_UINT64,
	PROFILE_FIELD_DOUBLE
} acct_gather_profile_field_type_t;

and the while loop condition ensures that PROFILE_FIELD_NOT_SET is not
handled. So instead of handling PROFILE_FIELD_NOT_SET directly, just
catching everything else with the "default" case statement and
continuing the loop.

when compiling with optimizations (-02) due to "size" not being set in
case statement.

when compiling with optimizations (-O2).

Could happen if the switch statement hit the default.
Was originally this way in ca682973

as stated in README.
Was originally this way in ca682973

relies on the primary to do so.

There is a potential race condition if the backup DBD tries to create/check the
database at the same time as the primary.  This patch removes this race by not
allowing the backup to do the check/create.

Bug 3827

Coverity CID 171481

Coverity CID 45152

Coverity CID 44923

Coverity CID 44802

Coverity 44943, 44944

Coverity CID 44941, 44942

Starting in MariaDB 10.2 many of the api commands started
setting errno erroneously.

Looks like it was used as test program.

Test was sporadically failing on smd without sleep

bug 4095

Coverity CID 166003

Coverity CID 44775

Coverity CID 44723

Corrections needed for variable type change in commit
91c847c1

This is needed to check range check for over/underflow by strtol.
Coverity CID 44779

Coverity CID 44776, 44777

Test was expecting the job name to be 'sh', when it may be 'bash'
or some other shell. Tweak the regex appropriately.

Bug 4110.

No real changes in logic
Coverity CID 44667, 44703, 44883, 153385

history.

Bug 4095

Testing if curl_handle != NULL or rc != SLURM_SUCCESS was already done
in the right above if/else statements, jumping to the consequent goto
cleanup label if needed. Thus the removed test was never going to be
evaluated to true, and Coverity properly warned about this.

Regression introduced in commit 5f5e6472 (code cleanup).

Calling bit_unfmt() with a zero bit_size() bitmap leads to a later
call to bit_nclear() with start=0 and stop=-1, leading to the ABRT.

This scenario happened when cgroup.conf has ConstrainDevices=yes and
task_cgroup_devices_create() tries to collect the GRES devices
but gres_cpu_cnt=0, thus creating a p->cpus_bitmap = bit_alloc(gres_cpu_cnt);
of zero size which is passed by argument to bit_unfmt().

gres_cpu_cnt is 0 because we have defined a gres.conf like this:

Name=gpu Type=tesla File=/tmp/gres/tesla0 CPUs=0,1
Name=gpu Type=tesla File=/tmp/gres/tesla1 CPUs=0,1
Name=gpu Type=kepler File=/tmp/gres/kepler0 CPUs=2,3
Name=gpu Type=kepler File=/tmp/gres/kepler1 CPUs=2,3

but have no GresTypes nor GRES option in the slurm.conf / node config def.

Bug 3974

Bug 3217