Prevents correct error handling by rc being 0/1 instead of the original
return code.

Also fix slurm_send_only_controller_msg and slurm_send_only_node_msg
although these only result in bad printed values in the debug message.

Bug 2120

This bug was introduced by commit 21c52d2f
which fixed a different problem tracking resources associated with suspended
jobs. There are subtle differences between jobs that are suspended by a
user/administrator and jobs suspended by gang scheduling which resulted in
undercounting allocated CPUs when a job suspended by gang scheduling
was active at the same time of a slurmctld reconfiguration request.
See bugs 2353 (original bug related to commit 21c52d2f
and bug 2765

accounts) no default account is printed, previously NULL was printed.

This is just not printing it, but whole function should probably be
revisited as the rigmarole can probably be avoided as we always know what
the default is going to be if none is specified (first off the list).

The problem with that though is if the user has been added to a cluster
already and they have a default, but then added to a new cluster where
they don't have a default.  In this case you want to keep the first
clusters default, but set the default for the second cluster.

Bug 2725

Add missing unlock before return. Coverity 44888.

This reverts commit cc242de3
That patch fixed bug 2745, but breaks tests 1.89 and 1.91 on
typical Xeon processors

This bug was introduced by commit 21c52d2f
which fixed a different problem tracking resources associated with suspended
jobs. There are subtle differences between jobs that are suspended by a
user/administrator and jobs suspended by gang scheduling which resulted in
undercounting allocated CPUs when a job suspended by gang scheduling
was active at the same time of a slurmctld reconfiguration request.
See bugs 2353 (original bug related to commit 21c52d2f
and bug 2765

accounts) no default account is printed, previously NULL was printed.

This is just not printing it, but whole function should probably be
revisited as the rigmarole can probably be avoided as we always know what
the default is going to be if none is specified (first off the list).

The problem with that though is if the user has been added to a cluster
already and they have a default, but then added to a new cluster where
they don't have a default.  In this case you want to keep the first
clusters default, but set the default for the second cluster.

Bug 2725

Fix for uninitialized variable in task binding logic, could leave tasks
    with fewer CPUs than intended.
bug 2766

Add missing unlock before return. Coverity 44888.

Coverity 44891.

sizeof(optarg) is incorrect, that's the size of the pointer
not the length of the character string that must be parsed.

Coverity 53128.

Coverity 44992.

Needs to unlock here, not re-lock the lock.

Prevent '--preserve' from being inadvertanly enabled by '-j'.

Logic introduced in v16.05.0-rc2 could attempt state change for
nid00000, even if no such node exists
bug 2758

Change how Slurm determines the NUMA count of a node. Ignore KNL NUMA
    that only include memory.
bug 2745

Need thread_id to distinguish between multiple threads with the same
name.

and the slurmctld doesn't wait long enough for the response it would give
up leaving the connection open and create a situation where the next message
sent could receive the response of the first one.

Bug 2739

Correct logic that calculates a step's cpus_per_task allocation
on a heterogenous job allocation. Mixing a KNL with a Xeon resulted
in a count that was between the CPU count on the two node types
and invalid on the node with smaller CPU count (e.g. 272 CPUs on
KNL, 8 on Xeon, and 2 tasks, cpus_per_task = 140).

Bug #2713.

Bug #2713.

Update slurm.spec file to have seff depend on slurm-perlapi.

when in use.

The problem here is the polling threads in the various acct_gather codes
were detached and could possibly still be polling after the plugin had
been unloaded making a seg fault with a backtrace like this...

#0  0x00007fe7af008c00 in ?? ()
#1  0x00007fe7b1138479 in __nptl_deallocate_tsd () at pthread_create.c:175
#2  0x00007fe7b11398b0 in __nptl_deallocate_tsd () at pthread_create.c:326
#3  start_thread (arg=0x7fe7b1f12700) at pthread_create.c:346
#4  0x00007fe7b0e6fb5d in clone ()
    at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109

The fix was to make the threads non-detached and join them before calling
a dlclose.

Whenever possible, avoid allocating nodes that require a reboot.
Previous logic failed to re-sort the job set table based upon
the need for rebooting to achieve the desired features (e.g. KNL
MCDRAM or CACHE mode).
bug 2726

trying to verify the cluster name (which may try to /create/ files or
directories) *before* dropping privs results in a fatal error as
slurmctld tries to create items which ultimately fail.  Moving
this process until after the privs and uid have changed allows
the process to succeed.

Reported by Jon Nelson <jdnelson@dyn.com>

Bug 2728

Reject invalid step at submit time rather than leaving it queued.
Bug 2722 describes one of the use cases triggering the bug.