Skip to content
Snippets Groups Projects
  1. Oct 27, 2017
  2. Oct 25, 2017
    • Danny Auble's avatar
      Fix layouts code to only allow setting a boolean. · b9273782
      Danny Auble authored
      Before it would allow all sorts of things like
      adding/subtracting/multiplying/etc.  It would cause warnings such as
      
      /home/bart/slurm-tmp5/src/common/layouts_mgr.c: In function ‘_layouts_load_automerge’:
      /home/bart/slurm-tmp5/src/common/layouts_mgr.c:363:21: error: ‘*’ in boolean context, suggest ‘&&’ instead [-Werror=int-in-bool-context]
         *lvalue = *lvalue * *rvalue;     \
                   ~~~~~~~~^~~~
      /home/bart/slurm-tmp5/src/common/layouts_mgr.c:1034:4: note: in expansion of macro ‘_entity_update_kv_helper’
          _entity_update_kv_helper(type_t, operator); \
          ^~~~~~~~~~~~~~~~~~~~~~~~
      /home/bart/slurm-tmp5/src/common/layouts_mgr.c:1086:4: note: in expansion of macro ‘_layouts_load_merge’
          _layouts_load_merge(bool, s_p_get_boolean);
      [tag] [reply] [−] Private Comment 16
      
      Bug 4062
      b9273782
    • Felip Moll's avatar
      Work around issue with sysmacros.h and gcc7 / glibc 2.25. · 8706f388
      Felip Moll authored
      Setting -Werror tricks the test into failing on the
      
      "error: In the GNU C Library, "major" is defined by <sys/sysmacros.h>.
       For historical compatibility, it is  currently defined by <sys/types.h>
       as well, but we plan to remove this soon. To use "major", include
       <sys/sysmacros.h> directly. If you did not intend to use a system-defined
       macro "major", you should undefine it after including <sys/types.h>."
      
      error. Since the normal Slurm build uses -Werror, this warning on including
      both headers will then cause the build itself to fail.
      
      Bug 3982.
      8706f388
  3. Oct 24, 2017
  4. Oct 20, 2017
  5. Oct 19, 2017
  6. Oct 18, 2017
  7. Oct 17, 2017
  8. Oct 14, 2017
  9. Oct 13, 2017
  10. Oct 10, 2017
Loading