This reverts commit 8343365f.

Fix double free issue from commit 3851f619

Same issue from fixed in a different spot with b19637bd.

Bug 3617

steps.

bug 3610

Bug 3097

Fix correct macro this time, Tim Wickberg's fault for prior failed patch.

Bug 3605.

This reverts commit 53523c54.

Bug 3605.

This reverts commit 979db782.

Partial backport from 17.11 commit 4874f988.

Bug 2484

This reverts commit 9fb8a8a3.

Association.

This reverts commits 92d2c645 and 37be42ec.  This caused incorrect
behavior, original code was correct.  This also corrects documentation additions
in commit 4cfe6bde.

This code caused the first clause never to be correct and if you were
over the limit you would get the third clause reporting a huge number available
where it should be a negative number.  The reality is the first clause should
had been triggered and handled correctly.

This reverts commit af52111c.

Association.

This reverts commits 92d2c645 and 37be42ec.  This caused incorrect
behavior, original code was correct.  This also corrects documentation additions
in commit 4cfe6bde.

This code caused the first clause never to be correct and if you were
over the limit you would get the third clause reporting a huge number available
where it should be a negative number.  The reality is the first clause should
had been triggered and handled correctly.

system.

What this patch does is looks at the partition the job is running in to get
the cpus per node off the first node in the partition.  Before it would
just look at the first node on the system which isn't that great on a
heterogeneous system.

Bug 3486

Bug 3577.

other half go to libslurmdb.so.

Turns out in 17.11 if you are using --with-shared-libslurm sacct will link to
both libslurmfull.so and libslurmdb.so.  In the case of linking to the
accounting_storage/slurmdbd plugin it will callback to slurmdbd_defs_init
which would be in libslurmdb.so but the call to acct_storage_p_get_connection
would call slurm_open_slurmdbd_conn which is in libslurmfull.so and it would
xassert on slurmdbd_defs_inited which was set in libslurmdb.so but not in
libslurmfull.so.

So the moral of the story is don't export half a file in one lib and the other
half in a different lib.

Perhaps we should only have 1 lib all together, but that isn't the way it is
done today.  This fixes the issue and has the entire file exported to
libslurmfull.so so we should be good.  But just a note for the future.

This was an unexpected regression caused by commit 5a5347c7.

Bug 3530

NOTE: there does appear to be other issues here, but we didn't fell comfortable
changing this many things in 17.02 for fear of breaking something.

This only fixes a bit of the issue as it appears node_scheduler.c has a fuller
test for these.  In 17.11 I plan to make this a function that will fill in
the min, req, max nodes and use it in both places in the code to prevent this
from happening again.