This should only happen due to ESLURM_RESULT_TOO_LARGE,
which leads to no list being packed.

Follow on to 390da8cf / 8cf1835c.

Bug 3624.

launch_g_step_wait() function.

Bug 4094

Coverity CID 166001

Coverity CID 44725, 44726, 44747, 44728

Coverity CID 44968

Coverity CID 44810

Coverity CID 53126

Coverity CID 53127

Coverity CID 44761

Coverity CID 44696

Coverity CID 44729

Coverity CID 44700

The exit status value for these two fields was incorrectly saved as-is.  The
patch makes use of the appropiate macros to properly decode the low-order
8 bits of the exit status and the signal number (if any).

bug 3942

Given a configuration with TopologyParam including Dragonfly option, if a
job requested --switches count, the count timeout specified by either
the job request or max_switch_wait SchedulerParameters was not respected.
This was due to leaf_switch_count variable not being incremented in
_eval_nodes_dfly() function when needed, as we do in _eval_nodes_topo(),
the later being a execution path which already succeed to wait for the
switch count timeout.

Bug 4056

Add the following fields as environment variables:
CLUSTER, DEPENDENCY, DERIVEDEC, EXITCODE, GROUPNAME, QOS, RESERVATION,
USERNAME.

LIMIT env variable value format (which means the TimeLimit of the job)
has been modified to D-HH:MM:SS.

Bug 3942

Coverity CID 48914

Coverity CID 44649

Bug 4085

Coverity CID 44678

Coverity CID 44728

Coverity CID 44732

Coverity CID 44778

instead of local.

Bug 3546

Coverity CID 44959

Coverity CID 171461

Coverity CID 44722

This insures that the batch script can have appropriate environment
  variables set for all components (i.e. the node list, cpu count,
  etc. for all pack groups).

This reverts commit 00a691b9.

This will allow dell's custom syscfg to work correctly.

NOTE: Dell calls flat memory just memory.

Bug 4034

No code change, just moving existing code into a switch ready to handle
multiple options.

Bug 4034

Add SystemType to knl_generic.conf for knl_generic in preparations for making KNL work on a Dell system.

Add SystemType to knl_generic.conf.  This is used to distinguish
differences in vendors such as 'Dell'.

    Bug 4034

Properly set up debugger symbols if an srun command tries to
  launch multiple, different applications in different components
  of a heterogeneous job (i.e. a different application in each
  pack job component).

This is needed to run a single MPI_COMM_WORLD spread across multiple
  job allocations. The work is incomplete, but well underway in this
  commit (much of the code in place, test suite runs sucessfully).

Otherwise the log will be spammed with "Buffer size limit exceeded".

Bug 3624.

Ensure proper termination in places that were otherwise missing
it, and remove some awkward termination handling in other locations.