bug 3099

This reverts commit e92b49d3.

No functional change.

instead of also in the backfill scheduler.

Bug 3405.

acct_policy_job_runnable_pre_select() calls assoc_mgr_set_qos_tres_cnt()
without tres READ_LOCK.

Note that existing code does not modify the tres structures, so this
cannot currently lead to a race condition.

Bug 3406.

job_submit/cnode was previously removed by commit 63bc71ed.

Bug 3403.

Bug 3395

burst_buffer/cray - Avoid "pre_run" operation if not using buffer (i.e.
    just creating or deleting a persistent burst buffer).
bug 3391

Previous job state information was "PENDING" rather than "REQUEUED"
  for each job requeued due to a burst buffer error.
bug 3388

scheduling a Datawarp job.

The assoc_mgr lock needs to happen before the bb_state.bb_mutex.  One place
this could cause deadlock is from src/slurmctld/controller.c
_accounting_cluster_ready() which calls clusteracct_storage_g_cluster_tres
which inturn calls bb_g_job_set_tres_cnt which calls bb_p_job_set_tres_cnt
which will lock the bb_muxtex after the assoc_mgr is already locked.

Bug 3389

Cache results of bit_set_count() calls.

Bug 3393.

Accidentally commited to Slurm version 16.05 instead of master

3 places where a string pointer referenced an out-of-scope memory location
1 memory leak and
1 unterminated string

backfill scheduler: Stop trying to determine expected start time for a job
    after 2 seconds of wall time. This can happen if there are many running jobs
    and a pending job can not be started soon.
byg 3373

mobile devices didn't behave as expected.

some of the tables (prolog_epilog) were hard to read.

Bug 3364.

Bug 3376.

Fix security issue caused by insecure file path handling triggered by
the failure of a Prolog script. To exploit this a user needs to
anticipate or cause the Prolog to fail for their job.

(This commit is slightly different from the fix to the 15.08 branch.)

CVE-2016-10030.

Fix security issue caused by insecure file path handling triggered by
the failure of a Prolog script. To exploit this a user needs to
anticipate or cause the Prolog to fail for their job.

CVE-2016-10030.

This modifies the logic in commit e089b63a for better clarity

Prevent "stray" jobs from using resources when the srun/salloc
will never launch the actual compute tasks.

Bug 3344.

PluginDir is allowed to be a PATH-style list of directories; remove
incorrect test of the variable as if it were a single directory and
comment that the check for that is elsewhere.

Bug 3361.

Expect is unable to work with more than 32-bit numbers, so it can't
properly test task affinity on KNL with 272 threads

- 2 x Integer handling issues (CONSTANT_EXPRESSION_RESULT)

Warning flag -Wempty-body in clang-3.7 now errors on this, split
macro definition up over multiple lines to silence.

Revision to 06fbdd75
  Previous logic was causing tests 1.87 and 15.19 to fail sometimes
  due to a race condition by adding a "Job allocation revoked"
  message to salloc output even if no allocation occured.
bug 3351