Logic was removed in 9b1845a35ee3f.
Since if a federated job that can start now only sets the one sibling as
viable (used as an optimization to start jobs jobs without having to get
the lock from the origin), the viable siblings need to be gotten again.

to validate cluster features.

Add and remove siblings jobs based off new cluster features.

Now viable siblings -- siblings where siblings job could run on
(e.g. after requested cluster and cluster features applied) and active
siblings are distinguished. The remote sibling jobs only need to know
about the viable siblings and not the actual siblings. This simplies
things a little bit by not having to update the remote sibling jobs when
the active siblings change (e.g. cluster rejects the submission), only
when the viable siblings are changed (scontrol update clusterfeatures).

To catch locks going negative while in development.

Don't need to check for the cluster pointer.

For copying one char_list into another.

And reset the iterator so that fb,fb doesn't get added twice.

I found today that SIGTERM'ed jobs show as OOM'ed in the database today.
From this commit:
commit 2a75b72d
A job terminating with SIG_TERM (and others) will incorrectly report
the job termination state as Out Of Memory.

# Conflicts:
#	src/slurmctld/acct_policy.c

Association.

This reverts commits 92d2c645 and 37be42ec.  This caused incorrect
behavior, original code was correct.  This also corrects documentation additions
in commit 4cfe6bde.

This code caused the first clause never to be correct and if you were
over the limit you would get the third clause reporting a huge number available
where it should be a negative number.  The reality is the first clause should
had been triggered and handled correctly.

This reverts commit af52111c.

Association.

This reverts commits 92d2c645 and 37be42ec.  This caused incorrect
behavior, original code was correct.  This also corrects documentation additions
in commit 4cfe6bde.

This code caused the first clause never to be correct and if you were
over the limit you would get the third clause reporting a huge number available
where it should be a negative number.  The reality is the first clause should
had been triggered and handled correctly.

conversion process easier.

a SUM of the steps to the job table.