Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
S
Slurm
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
tud-zih-energy
Slurm
Commits
df46b805
Commit
df46b805
authored
15 years ago
by
Moe Jette
Browse files
Options
Downloads
Patches
Plain Diff
make cancel of job step go to slurmctld rather than directly to slurmd
so we can better log the event
parent
b62ceaf4
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/scancel/opt.c
+3
-2
3 additions, 2 deletions
src/scancel/opt.c
src/scancel/scancel.c
+6
-3
6 additions, 3 deletions
src/scancel/scancel.c
with
9 additions
and
5 deletions
src/scancel/opt.c
+
3
−
2
View file @
df46b805
...
...
@@ -17,7 +17,7 @@
* any later version.
*
* In addition, as a special exception, the copyright holders give permission
* to link the code of portions of this program with the OpenSSL library unde
r
* to link the code of portions of this program with the OpenSSL library unde
* certain conditions as described in each individual source file, and
* distribute linked combinations including the two. You must obey the GNU
* General Public License in all respects for all of the code used other than
...
...
@@ -352,7 +352,8 @@ static void _opt_args(int argc, char **argv)
switch
(
opt_char
)
{
case
(
int
)
'?'
:
fprintf
(
stderr
,
"Try
\"
scancel --help
\"
for more information
\n
"
);
"Try
\"
scancel --help
\"
for more "
"information
\n
"
);
exit
(
1
);
break
;
case
(
int
)
'b'
:
...
...
This diff is collapsed.
Click to expand it.
src/scancel/scancel.c
+
6
−
3
View file @
df46b805
...
...
@@ -17,7 +17,7 @@
* any later version.
*
* In addition, as a special exception, the copyright holders give permission
* to link the code of portions of this program with the OpenSSL library under
* to link the code of portions of this program with the OpenSSL library under
* certain conditions as described in each individual source file, and
* distribute linked combinations including the two. You must obey the GNU
* General Public License in all respects for all of the code used other than
...
...
@@ -445,9 +445,12 @@ _cancel_step_id (void *ci)
uint32_t
job_id
=
cancel_info
->
job_id
;
uint32_t
step_id
=
cancel_info
->
step_id
;
uint16_t
sig
=
cancel_info
->
sig
;
bool
sig_set
=
true
;
if
(
sig
==
(
uint16_t
)
-
1
)
if
(
sig
==
(
uint16_t
)
-
1
)
{
sig
=
SIGKILL
;
sig_set
=
false
;
}
for
(
i
=
0
;
i
<
MAX_CANCEL_RETRY
;
i
++
)
{
if
(
sig
==
SIGKILL
)
...
...
@@ -457,7 +460,7 @@ _cancel_step_id (void *ci)
sig
,
job_id
,
step_id
);
}
if
(
opt
.
ctld
)
if
(
(
!
sig_set
)
||
opt
.
ctld
)
error_code
=
slurm_kill_job_step
(
job_id
,
step_id
,
sig
);
else
if
(
sig
==
SIGKILL
)
error_code
=
slurm_terminate_job_step
(
job_id
,
step_id
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment