Skip to content
Snippets Groups Projects
Commit d84fc141 authored by Danny Auble's avatar Danny Auble
Browse files

--enable-debug no longer has to be stated at configure time to have the...

--enable-debug no longer has to be stated at configure time to have the slurmctld or slurmstepd dump core on a seg fault.
parent 1ea41b26
No related branches found
No related tags found
No related merge requests found
...@@ -15,6 +15,8 @@ documents those changes that are of interest to users and admins. ...@@ -15,6 +15,8 @@ documents those changes that are of interest to users and admins.
-- Applied patch from Mark Grondona that tests for a missing config file before -- Applied patch from Mark Grondona that tests for a missing config file before
any other processing in spank_init(). This now prevents fatal errors from any other processing in spank_init(). This now prevents fatal errors from
being mistakenly treated as recoverable. being mistakenly treated as recoverable.
-- --enable-debug no longer has to be stated at configure time to have
the slurmctld or slurmstepd dump core on a seg fault.
* Changes in SLURM 2.1.0-pre5 * Changes in SLURM 2.1.0-pre5
============================= =============================
......
...@@ -254,12 +254,10 @@ int main(int argc, char *argv[]) ...@@ -254,12 +254,10 @@ int main(int argc, char *argv[])
if (license_init(slurmctld_conf.licenses) != SLURM_SUCCESS) if (license_init(slurmctld_conf.licenses) != SLURM_SUCCESS)
fatal("Invalid Licenses value: %s", slurmctld_conf.licenses); fatal("Invalid Licenses value: %s", slurmctld_conf.licenses);
#ifndef NDEBUG #ifdef PR_SET_DUMPABLE
# ifdef PR_SET_DUMPABLE
if (prctl(PR_SET_DUMPABLE, 1) < 0) if (prctl(PR_SET_DUMPABLE, 1) < 0)
debug ("Unable to set dumpable to 1"); debug ("Unable to set dumpable to 1");
# endif /* PR_SET_DUMPABLE */ #endif /* PR_SET_DUMPABLE */
#endif /* !NDEBUG */
/* /*
* Create StateSaveLocation directory if necessary. * Create StateSaveLocation directory if necessary.
......
...@@ -844,12 +844,10 @@ job_manager(slurmd_job_t *job) ...@@ -844,12 +844,10 @@ job_manager(slurmd_job_t *job)
goto fail1; goto fail1;
} }
#ifndef NDEBUG #ifdef PR_SET_DUMPABLE
# ifdef PR_SET_DUMPABLE
if (prctl(PR_SET_DUMPABLE, 1) < 0) if (prctl(PR_SET_DUMPABLE, 1) < 0)
debug ("Unable to set dumpable to 1"); debug ("Unable to set dumpable to 1");
# endif /* PR_SET_DUMPABLE */ #endif /* PR_SET_DUMPABLE */
#endif /* !NDEBUG */
set_umask(job); /* set umask for stdout/err files */ set_umask(job); /* set umask for stdout/err files */
if (job->user_managed_io) if (job->user_managed_io)
......
...@@ -122,10 +122,16 @@ int main(int argc, char *argv[]) ...@@ -122,10 +122,16 @@ int main(int argc, char *argv[])
_kill_old_slurmdbd(); _kill_old_slurmdbd();
if (foreground == 0) if (foreground == 0)
_daemonize(); _daemonize();
_init_pidfile(); _init_pidfile();
_become_slurm_user(); _become_slurm_user();
log_config(); log_config();
#ifdef PR_SET_DUMPABLE
if (prctl(PR_SET_DUMPABLE, 1) < 0)
debug ("Unable to set dumpable to 1");
#endif /* PR_SET_DUMPABLE */
if (xsignal_block(dbd_sigarray) < 0) if (xsignal_block(dbd_sigarray) < 0)
error("Unable to block signals"); error("Unable to block signals");
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment