modify some error messages for greater clarity

testsuite/expect/regression

@@ -40,7 +40,7 @@ if [ ! -x ./regression ]; then
 	exit 1
 fi
 if [ ! -x ./globals ]; then
-	echo "FAILURE: copy 'globals.example' to 'globals' and modify as needed"
+	echo "FAILURE: 'globals' file not found"
 	exit 1
 fi
 

testsuite/expect/test1.44

@@ -8,7 +8,8 @@
 #          "FAILURE: ..." otherwise with an explanation of the failure, OR
 #          anything else indicates a failure mode that must be investigated.
 ############################################################################
-# Copyright (C) 2005 The Regents of the University of California.
+# Copyright (C) 2002-2007 The Regents of the University of California.
+# Copyright (C) 2008 Lawrence Livermore National Security.
 # Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
 # Written by Chris Morrone <morrone2@llnl.gov>
 # LLNL-CODE-402394.
@@ -97,7 +98,11 @@ for {set inx 0} {$inx < $cycle_count} {incr inx} {
 		set stdout_lines [get_line_cnt $file_out]
 	}
 	if {$stdout_lines != $stdout_target} {
-		send_user "\nFAILURE: stdout is incomplete\n"
+		if {$stdout_lines == 0} {
+			send_user "\nFAILURE: stdout is empty, is current working directory writable from compute nodes?\n"
+		} else {
+			send_user "\nFAILURE:stdout is incomplete\n"
+		}
 	        set exit_code 1
 	        break
 	} else {

testsuite/expect/test9.1

@@ -9,7 +9,8 @@
 # Note:    This script generates and then deletes files in the working directory 
 #          named test9.1.input and test9.1.output
 ############################################################################
-# Copyright (C) 2002 The Regents of the University of California.
+# Copyright (C) 2002-2007 The Regents of the University of California.
+# Copyright (C) 2008 Lawrence Livermore National Security.
 # Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
 # Written by Morris Jette <jette1@llnl.gov>
 # LLNL-CODE-402394.
@@ -105,7 +106,11 @@ for {set inx 0} {$inx < $cycle_count} {incr inx} {
 		set stdout_lines [get_line_cnt $file_out]
 	}
 	if {$stdout_lines != $stdout_target} {
-		send_user "\nFAILURE: stdout is incomplete\n"
+		if {$stdout_lines == 0} {
+			send_user "\nFAILURE: stdout is empty, is current working directory writable from compute nodes?\n"
+		} else {
+			send_user "\nFAILURE:stdout is incomplete\n"
+		}
 		set cycle_count [expr $inx + 1]
 		set exit_code 1
 		break

testsuite/expect/test9.2

@@ -9,7 +9,8 @@
 # Note:    This script generates and then deletes files in the working directory 
 #          named test9.2.output
 ############################################################################
-# Copyright (C) 2002-2006 The Regents of the University of California.
+# Copyright (C) 2002-2007 The Regents of the University of California.
+# Copyright (C) 2008 Lawrence Livermore National Security.
 # Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
 # Written by Morris Jette <jette1@llnl.gov>
 # LLNL-CODE-402394.
@@ -95,7 +96,11 @@ for {set inx 0} {$inx < $cycle_count} {incr inx} {
 		set stdout_lines [get_line_cnt $file_out]
 	}
 	if {$stdout_lines != $task_cnt} {
-		send_user "\nFAILURE:stdout is incomplete\n"
+		if {$stdout_lines == 0} {
+			send_user "\nFAILURE: stdout is empty, is current working directory writable from compute nodes?\n"
+		} else {
+			send_user "\nFAILURE:stdout is incomplete\n"
+		}
 		set cycle_count [expr $inx + 1]
 		set exit_code 1
 		break

testsuite/expect/test9.3

@@ -9,7 +9,8 @@
 # Note:    This script generates and then deletes files in the working directory 
 #          named test9.3.output
 ############################################################################
-# Copyright (C) 2002-2006 The Regents of the University of California.
+# Copyright (C) 2002-2007 The Regents of the University of California.
+# Copyright (C) 2008 Lawrence Livermore National Security.
 # Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
 # Written by Morris Jette <jette1@llnl.gov>
 # LLNL-CODE-402394.
@@ -105,7 +106,11 @@ for {set inx 0} {$inx < $cycle_count} {incr inx} {
 		set stdout_lines [get_line_cnt $file_out]
 	}
 	if {$stdout_lines != $stdout_target} {
-		send_user "\nFAILURE:stdout is incomplete\n"
+		if {$stdout_lines == 0} {
+			send_user "\nFAILURE: stdout is empty, is current working directory writable from compute nodes?\n"
+		} else {
+			send_user "\nFAILURE:stdout is incomplete\n"
+		}
 		set cycle_count [expr $inx + 1]
 		set exit_code 1
 		break

testsuite/expect/test9.4

@@ -10,10 +10,12 @@
 #          we create them ahead of time. Without explicity file creation, 
 #          this test requires about one minute per cycle to execute.
 #
-# Note:    This script generates and then deletes files in the working directory
-#          named test9.4.input, test9.4.[0-9]+.input, and test9.4.[0-9]+.output
+# Note:    This script generates and then deletes files in the working 
+#          directory named test9.4.input, test9.4.[0-9]+.input, and
+#          test9.4.[0-9]+.output
 ############################################################################
-# Copyright (C) 2002-2006 The Regents of the University of California.
+# Copyright (C) 2002-2007 The Regents of the University of California.
+# Copyright (C) 2008 Lawrence Livermore National Security.
 # Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
 # Written by Morris Jette <jette1@llnl.gov>
 # LLNL-CODE-402394.
@@ -135,7 +137,11 @@ for {set inx 0} {$inx < $cycle_count} {incr inx} {
 			set stdout_lines [get_line_cnt $file_out_glob]
 		}
 		if {$stdout_lines != $stdin_lines} {
-			send_user "\nFAILURE:stdout is incomplete\n"
+			if {$stdout_lines == 0} {
+				send_user "\nFAILURE: stdout is empty, is current working directory writable from compute nodes?\n"
+			} else {
+				send_user "\nFAILURE:stdout is incomplete\n"
+			}
 			set exit_code 1
 		} else {
 			incr success_cnt

testsuite/expect/test9.5

@@ -6,7 +6,8 @@
 #          "FAILURE: ..." otherwise with an explanation of the failure, OR
 #          anything else indicates a failure mode that must be investigated.
 ############################################################################
-# Copyright (C) 2002-2006 The Regents of the University of California.
+# Copyright (C) 2002-2007 The Regents of the University of California.
+# Copyright (C) 2008 Lawrence Livermore National Security.
 # Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
 # Written by Morris Jette <jette1@llnl.gov>
 # LLNL-CODE-402394.
@@ -119,7 +120,11 @@ for {set inx 0} {$inx < $cycle_count} {incr inx} {
 		set stdout_lines [get_line_cnt $file_out]
 	}
 	if {$stdout_lines != $stdout_target} {
-		send_user "\nFAILURE:stdout is missing output\n"
+		if {$stdout_lines == 0} {
+			send_user "\nFAILURE: stdout is empty, is current working directory writable from compute nodes?\n"
+		} else {
+			send_user "\nFAILURE:stdout is incomplete\n"
+		}
 		set exit_code 1
 	} else {
 		incr success_cnt

testsuite/expect/test9.6

@@ -6,10 +6,11 @@
 #          "FAILURE: ..." otherwise with an explanation of the failure, OR
 #          anything else indicates a failure mode that must be investigated.
 #
-# Note:    This script generates and then deletes files in the working directory 
+# Note:    This script generates and then deletes files in the working directory
 #          named test9.6.input and test9.6.output
 ############################################################################
-# Copyright (C) 2002-2006 The Regents of the University of California.
+# Copyright (C) 2002-2007 The Regents of the University of California.
+# Copyright (C) 2008 Lawrence Livermore National Security.
 # Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
 # Written by Morris Jette <jette1@llnl.gov>
 # LLNL-CODE-402394.
@@ -102,11 +103,15 @@ for {set inx 0} {$inx < $cycle_count} {incr inx} {
 	}
 	set stdout_lines [get_line_cnt $file_out]
 	if {$stdout_lines != $stdout_target} {
-		 exec $bin_sleep 1
+		exec $bin_sleep 1
 		set stdout_lines [get_line_cnt $file_out]
 	}
 	if {$stdout_lines != $stdout_target} {
-		send_user "\nFAILURE:stdout is missing output\n"
+		if {$stdout_lines == 0} {
+			send_user "\nFAILURE: stdout is empty, is current working directory writable from compute nodes?\n"
+		} else {
+			send_user "\nFAILURE:stdout is incomplete\n"
+		}
 		set cycle_count [expr $inx + 1]
 		set exit_code 1
 		break