Skip to content
Snippets Groups Projects
Commit c6a67445 authored by Moe Jette's avatar Moe Jette
Browse files

enhance some error logging

parent e162b11a
No related branches found
No related tags found
No related merge requests found
...@@ -2257,8 +2257,9 @@ extern int step_partial_comp(step_complete_msg_t *req, uid_t uid, ...@@ -2257,8 +2257,9 @@ extern int step_partial_comp(step_complete_msg_t *req, uid_t uid,
return SLURM_SUCCESS; return SLURM_SUCCESS;
} }
if (req->range_last < req->range_first) { if (req->range_last < req->range_first) {
error("step_partial_comp: JobID=%u range=%u-%u", error("step_partial_comp: StepID=%u.%u range=%u-%u",
req->job_id, req->range_first, req->range_last); req->job_id, req->job_step_id, req->range_first,
req->range_last);
return EINVAL; return EINVAL;
} }
...@@ -2268,8 +2269,10 @@ extern int step_partial_comp(step_complete_msg_t *req, uid_t uid, ...@@ -2268,8 +2269,10 @@ extern int step_partial_comp(step_complete_msg_t *req, uid_t uid,
/* initialize the node bitmap for exited nodes */ /* initialize the node bitmap for exited nodes */
nodes = bit_set_count(step_ptr->step_node_bitmap); nodes = bit_set_count(step_ptr->step_node_bitmap);
if (req->range_last >= nodes) { /* range is zero origin */ if (req->range_last >= nodes) { /* range is zero origin */
error("step_partial_comp: JobID=%u last=%u, nodes=%d", error("step_partial_comp: StepID=%u.%u last=%u "
req->job_id, req->range_last, nodes); "nodes=%d",
req->job_id, req->job_step_id, req->range_last,
nodes);
return EINVAL; return EINVAL;
} }
step_ptr->exit_node_bitmap = bit_alloc(nodes); step_ptr->exit_node_bitmap = bit_alloc(nodes);
...@@ -2279,8 +2282,10 @@ extern int step_partial_comp(step_complete_msg_t *req, uid_t uid, ...@@ -2279,8 +2282,10 @@ extern int step_partial_comp(step_complete_msg_t *req, uid_t uid,
} else { } else {
nodes = _bitstr_bits(step_ptr->exit_node_bitmap); nodes = _bitstr_bits(step_ptr->exit_node_bitmap);
if (req->range_last >= nodes) { /* range is zero origin */ if (req->range_last >= nodes) { /* range is zero origin */
error("step_partial_comp: JobID=%u last=%u, nodes=%d", error("step_partial_comp: StepID=%u.%u last=%u "
req->job_id, req->range_last, nodes); "nodes=%d",
req->job_id, req->job_step_id, req->range_last,
nodes);
return EINVAL; return EINVAL;
} }
step_ptr->exit_code = MAX(step_ptr->exit_code, req->step_rc); step_ptr->exit_code = MAX(step_ptr->exit_code, req->step_rc);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment