Skip to content
Snippets Groups Projects
Commit aa947d80 authored by Alejandro Sanchez's avatar Alejandro Sanchez Committed by Danny Auble
Browse files

Fix srun segfault caused by invalid memory reads on the env.

Bug 5561.
parent bb42aca2
No related branches found
No related tags found
No related merge requests found
...@@ -1300,6 +1300,8 @@ extern void pre_launch_srun_job(srun_job_t *job, bool slurm_started, ...@@ -1300,6 +1300,8 @@ extern void pre_launch_srun_job(srun_job_t *job, bool slurm_started,
slurm_step_launch_abort(job->step_ctx); slurm_step_launch_abort(job->step_ctx);
exit(error_exit); exit(error_exit);
} }
env_array_merge(&job->env, (const char **)__environ);
} }
extern void fini_srun(srun_job_t *job, bool got_alloc, uint32_t *global_rc, extern void fini_srun(srun_job_t *job, bool got_alloc, uint32_t *global_rc,
......
...@@ -597,7 +597,7 @@ static void _setup_one_job_env(slurm_opt_t *opt_local, srun_job_t *job, ...@@ -597,7 +597,7 @@ static void _setup_one_job_env(slurm_opt_t *opt_local, srun_job_t *job,
} }
setup_env(env, srun_opt->preserve_env); setup_env(env, srun_opt->preserve_env);
job->env = environ; env_array_merge(&job->env, (const char **)environ);
xfree(env->task_count); xfree(env->task_count);
xfree(env); xfree(env);
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment