Skip to content
Snippets Groups Projects
Commit 9a6ebac1 authored by Moe Jette's avatar Moe Jette
Browse files
parent 92212b34
No related branches found
No related tags found
No related merge requests found
...@@ -235,6 +235,11 @@ documents those changes that are of interest to users and admins. ...@@ -235,6 +235,11 @@ documents those changes that are of interest to users and admins.
the code) the code)
-- Added support for OSX build. -- Added support for OSX build.
* Changes in SLURM 1.1.32
=========================
- If a job's stdout/err file names are unusable (bad path), use the
default names.
* Changes in SLURM 1.1.31 * Changes in SLURM 1.1.31
========================= =========================
- Correctly identify a user's login shell when running "srun -b --uid" - Correctly identify a user's login shell when running "srun -b --uid"
......
...@@ -696,7 +696,12 @@ _init_task_stdio_fds(slurmd_task_info_t *task, slurmd_job_t *job) ...@@ -696,7 +696,12 @@ _init_task_stdio_fds(slurmd_task_info_t *task, slurmd_job_t *job)
O_CREAT|O_WRONLY|O_TRUNC|O_APPEND, 0666); O_CREAT|O_WRONLY|O_TRUNC|O_APPEND, 0666);
if (task->stdout_fd == -1) { if (task->stdout_fd == -1) {
error("Could not open stdout file: %m"); error("Could not open stdout file: %m");
return SLURM_ERROR; xfree(task->ofname);
task->ofname = fname_create(job, "slurm-%J.out", 0);
task->stdout_fd = open(task->ofname,
O_CREAT|O_WRONLY|O_TRUNC|O_APPEND, 0666);
if (task->stdout_fd == -1)
return SLURM_ERROR;
} }
fd_set_close_on_exec(task->stdout_fd); fd_set_close_on_exec(task->stdout_fd);
task->from_stdout = -1; /* not used */ task->from_stdout = -1; /* not used */
...@@ -729,7 +734,12 @@ _init_task_stdio_fds(slurmd_task_info_t *task, slurmd_job_t *job) ...@@ -729,7 +734,12 @@ _init_task_stdio_fds(slurmd_task_info_t *task, slurmd_job_t *job)
O_CREAT|O_WRONLY|O_TRUNC|O_APPEND, 0666); O_CREAT|O_WRONLY|O_TRUNC|O_APPEND, 0666);
if (task->stderr_fd == -1) { if (task->stderr_fd == -1) {
error("Could not open stderr file: %m"); error("Could not open stderr file: %m");
return SLURM_ERROR; xfree(task->efname);
task->efname = fname_create(job, "slurm-%J.err", 0);
task->stderr_fd = open(task->efname,
O_CREAT|O_WRONLY|O_TRUNC|O_APPEND, 0666);
if (task->stderr_fd == -1)
return SLURM_ERROR;
} }
fd_set_close_on_exec(task->stderr_fd); fd_set_close_on_exec(task->stderr_fd);
task->from_stderr = -1; /* not used */ task->from_stderr = -1; /* not used */
......
...@@ -238,7 +238,12 @@ job_step_create_allocation(uint32_t job_id) ...@@ -238,7 +238,12 @@ job_step_create_allocation(uint32_t job_id)
* the vars then. * the vars then.
*/ */
if (!opt.nodes_set) { if (!opt.nodes_set) {
if(opt.nprocs_set) /* we don't want to set the number of nodes =
* to the number of requested processes unless we
* know it is less than the number of nodes
* in the allocation
*/
if(opt.nprocs_set && (opt.nprocs < ai->nnodes))
opt.min_nodes = opt.nprocs; opt.min_nodes = opt.nprocs;
else else
opt.min_nodes = ai->nnodes; opt.min_nodes = ai->nnodes;
...@@ -293,7 +298,12 @@ job_step_create_allocation(uint32_t job_id) ...@@ -293,7 +298,12 @@ job_step_create_allocation(uint32_t job_id)
hostlist_destroy(hl); hostlist_destroy(hl);
} else { } else {
if (!opt.nodes_set) { if (!opt.nodes_set) {
if(opt.nprocs_set) /* we don't want to set the number of nodes =
* to the number of requested processes unless we
* know it is less than the number of nodes
* in the allocation
*/
if(opt.nprocs_set && (opt.nprocs < ai->nnodes))
opt.min_nodes = opt.nprocs; opt.min_nodes = opt.nprocs;
else else
opt.min_nodes = ai->nnodes; opt.min_nodes = ai->nnodes;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment