Skip to content
Snippets Groups Projects
Commit 778f47b9 authored by Artem Polyakov's avatar Artem Polyakov Committed by Danny Auble
Browse files

mpi/pmix: Fix a typo in I/O engine code

Replase "bool" with "int" as the return type of `pmixp_io_fd()`. This
was causing an interesting hidden bug affecting the performance.
Since this function was returning boolean value it was always
returning "1" instead of actual fd number. fd=1 is set to /dev/null
for slurmstepd, this is a char device that is always read/write ready
from the poll() perspective. So poll was continuously interrupting and
progress was fine, but CPU usage was ~100%.
parent b831f15e
No related branches found
No related tags found
No related merge requests found
...@@ -77,7 +77,7 @@ typedef struct { ...@@ -77,7 +77,7 @@ typedef struct {
List send_queue, complete_queue; List send_queue, complete_queue;
} pmixp_io_engine_t; } pmixp_io_engine_t;
static inline bool pmixp_io_fd(pmixp_io_engine_t *eng) static inline int pmixp_io_fd(pmixp_io_engine_t *eng)
{ {
return eng->sd; return eng->sd;
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment