Skip to content
Snippets Groups Projects
Commit 6641f85a authored by Morris Jette's avatar Morris Jette
Browse files

Fix recently introduced memory leaks on some system call failures

parent 42fa7322
No related branches found
No related tags found
No related merge requests found
...@@ -1033,6 +1033,7 @@ extern void queue_basil_signal(struct job_record *job_ptr, int signal, ...@@ -1033,6 +1033,7 @@ extern void queue_basil_signal(struct job_record *job_ptr, int signal,
if (pthread_attr_setdetachstate(&attr_sig_basil, if (pthread_attr_setdetachstate(&attr_sig_basil,
PTHREAD_CREATE_DETACHED)) { PTHREAD_CREATE_DETACHED)) {
error("pthread_attr_setdetachstate error %m"); error("pthread_attr_setdetachstate error %m");
slurm_attr_destroy(&attr_sig_basil);
return; return;
} }
args_sig_basil = xmalloc(sizeof(args_sig_basil_t)); args_sig_basil = xmalloc(sizeof(args_sig_basil_t));
...@@ -1042,6 +1043,8 @@ extern void queue_basil_signal(struct job_record *job_ptr, int signal, ...@@ -1042,6 +1043,8 @@ extern void queue_basil_signal(struct job_record *job_ptr, int signal,
if (pthread_create(&thread_sig_basil, &attr_sig_basil, if (pthread_create(&thread_sig_basil, &attr_sig_basil,
_sig_basil, (void *) args_sig_basil)) { _sig_basil, (void *) args_sig_basil)) {
error("pthread_create error %m"); error("pthread_create error %m");
slurm_attr_destroy(&attr_sig_basil);
xfree(args_sig_basil);
return; return;
} }
slurm_attr_destroy(&attr_sig_basil); slurm_attr_destroy(&attr_sig_basil);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment