Skip to content
Snippets Groups Projects
Commit 5657eda2 authored by Morris Jette's avatar Morris Jette
Browse files

Merge branch 'slurm-14.11'

parents b8cbad26 e6290537
No related branches found
No related tags found
No related merge requests found
...@@ -21,6 +21,7 @@ documents those changes that are of interest to users and administrators. ...@@ -21,6 +21,7 @@ documents those changes that are of interest to users and administrators.
Issue is only in rc1. Issue is only in rc1.
-- Add PrivateData value of "cloud". If set, powered down nodes in the cloud -- Add PrivateData value of "cloud". If set, powered down nodes in the cloud
will be visible. will be visible.
-- Sched/backfill - Eliminate clearing start_time of running jobs.
* Changes in Slurm 14.11.0rc1 * Changes in Slurm 14.11.0rc1
============================= =============================
......
...@@ -622,7 +622,7 @@ extern void *backfill_agent(void *args) ...@@ -622,7 +622,7 @@ extern void *backfill_agent(void *args)
return NULL; return NULL;
} }
/* Clear the start_time for all jobs. This is used to insure that a job which /* Clear the start_time for all pending jobs. This is used to insure that a job which
* can run in multiple partitions has its start_time set to the smallest * can run in multiple partitions has its start_time set to the smallest
* value in any of those partitions. */ * value in any of those partitions. */
static void _clear_job_start_times(void) static void _clear_job_start_times(void)
...@@ -631,8 +631,9 @@ static void _clear_job_start_times(void) ...@@ -631,8 +631,9 @@ static void _clear_job_start_times(void)
struct job_record *job_ptr; struct job_record *job_ptr;
job_iterator = list_iterator_create(job_list); job_iterator = list_iterator_create(job_list);
while ((job_ptr =(struct job_record *) list_next(job_iterator))) { while ((job_ptr = (struct job_record *) list_next(job_iterator))) {
job_ptr->start_time = 0; if (IS_JOB_PENDING(job_ptr))
job_ptr->start_time = 0;
} }
list_iterator_destroy(job_iterator); list_iterator_destroy(job_iterator);
} }
...@@ -838,8 +839,7 @@ static int _attempt_backfill(void) ...@@ -838,8 +839,7 @@ static int _attempt_backfill(void)
xfree(job_queue_rec); xfree(job_queue_rec);
continue; continue;
} }
if (backfill_continue) orig_start_time = job_ptr->start_time;
orig_start_time = job_ptr->start_time;
orig_time_limit = job_ptr->time_limit; orig_time_limit = job_ptr->time_limit;
part_ptr = job_queue_rec->part_ptr; part_ptr = job_queue_rec->part_ptr;
xfree(job_queue_rec); xfree(job_queue_rec);
......
...@@ -1698,7 +1698,7 @@ static int _will_run_test(struct job_record *job_ptr, bitstr_t *bitmap, ...@@ -1698,7 +1698,7 @@ static int _will_run_test(struct job_record *job_ptr, bitstr_t *bitmap,
select_node_usage, exc_core_bitmap); select_node_usage, exc_core_bitmap);
if (rc == SLURM_SUCCESS) { if (rc == SLURM_SUCCESS) {
FREE_NULL_BITMAP(orig_map); FREE_NULL_BITMAP(orig_map);
job_ptr->start_time = time(NULL); job_ptr->start_time = now;
return SLURM_SUCCESS; return SLURM_SUCCESS;
} }
......
...@@ -40,11 +40,16 @@ set proc "" ...@@ -40,11 +40,16 @@ set proc ""
set run_host "" set run_host ""
set make_file 0 set make_file 0
set exit_code 0 set exit_code 0
set pcmd_prog "/opt/cray/nodehealth/default/bin/pcmd"
print_header $test_id print_header $test_id
if {[test_cray]} { if {[test_cray]} {
set make_file 1 set make_file 1
if { [file exists $pcmd_prog] == 0 } {
send_user "\nFAILURE: The file $pcmd_prog was not found\n"
exit $exit_code
}
} }
if { [string compare [test_launch_type] "slurm"] } { if { [string compare [test_launch_type] "slurm"] } {
send_user "\nWARNING: This test is only compatible with systems using launch/slurm\n" send_user "\nWARNING: This test is only compatible with systems using launch/slurm\n"
...@@ -96,12 +101,12 @@ proc change_pro_epi { arg program_name conf_change task_pro } { ...@@ -96,12 +101,12 @@ proc change_pro_epi { arg program_name conf_change task_pro } {
} }
proc check_file { file_name } { proc check_file { file_name } {
global test_id exit_code file_dir run_host global test_id exit_code file_dir run_host pcmd_prog
sleep 1 sleep 1
set found 0 set found 0
spawn /opt/cray/nodehealth/default/bin/pcmd -n $run_host "find $file_dir -name $file_name" spawn $pcmd_prog -n $run_host "find $file_dir -name $file_name"
expect { expect {
-re "$file_dir/$file_name" { -re "$file_dir/$file_name" {
set found 1 set found 1
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment