Skip to content
Snippets Groups Projects
Commit 54430760 authored by Moe Jette's avatar Moe Jette
Browse files

Fix bug in job completion error logging.

parent 04a3f67f
No related branches found
No related tags found
No related merge requests found
...@@ -877,7 +877,8 @@ static void _slurm_rpc_job_step_complete(slurm_msg_t * msg) ...@@ -877,7 +877,8 @@ static void _slurm_rpc_job_step_complete(slurm_msg_t * msg)
complete_job_step_msg->slurm_rc = SLURM_SUCCESS; complete_job_step_msg->slurm_rc = SLURM_SUCCESS;
} }
if (complete_job_step_msg->slurm_rc != SLURM_SUCCESS) { if (complete_job_step_msg->slurm_rc != SLURM_SUCCESS) {
error("Fatal slurmd error running JobId=%u from node=%s: %s", error("Fatal slurmd error %u running JobId=%u on node=%s: %s",
complete_job_step_msg->slurm_rc,
complete_job_step_msg->job_id, complete_job_step_msg->job_id,
complete_job_step_msg->node_name, complete_job_step_msg->node_name,
slurm_strerror(complete_job_step_msg->slurm_rc)); slurm_strerror(complete_job_step_msg->slurm_rc));
......
...@@ -1088,7 +1088,7 @@ _complete_job(uint32_t jobid, int err, int status) ...@@ -1088,7 +1088,7 @@ _complete_job(uint32_t jobid, int err, int status)
slurm_msg_t req_msg; slurm_msg_t req_msg;
complete_job_step_msg_t req; complete_job_step_msg_t req;
req.job_id = jobid; req.job_id = jobid;
req.job_step_id = NO_VAL; req.job_step_id = NO_VAL;
req.job_rc = status; req.job_rc = status;
req.slurm_rc = err; req.slurm_rc = err;
......
...@@ -336,10 +336,10 @@ job_destroy(job_t *job, int error) ...@@ -336,10 +336,10 @@ job_destroy(job_t *job, int error)
if (job->old_job) { if (job->old_job) {
debug("cancelling job step %u.%u", job->jobid, job->stepid); debug("cancelling job step %u.%u", job->jobid, job->stepid);
slurm_kill_job_step(job->jobid, job->stepid, SIGKILL); slurm_kill_job_step(job->jobid, job->stepid, SIGKILL);
slurm_complete_job_step(job->jobid, job->stepid, 0, error); slurm_complete_job_step(job->jobid, job->stepid, error, 0);
} else if (!opt.no_alloc) { } else if (!opt.no_alloc) {
debug("cancelling job %u", job->jobid); debug("cancelling job %u", job->jobid);
slurm_complete_job(job->jobid, 0, error); slurm_complete_job(job->jobid, error, 0);
} else { } else {
debug("no allocation to cancel, killing remote tasks"); debug("no allocation to cancel, killing remote tasks");
fwd_signal(job, SIGKILL); fwd_signal(job, SIGKILL);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment