Remove remnants of mkdir_parent on log file and pid file create.

Just log open failure and continue.

src/common/daemonize.c

@@ -36,7 +36,6 @@
 #include "src/common/fd.h"
 #include "src/common/log.h"
 #include "src/common/macros.h"
-#include "src/common/safeopen.h"
 #include "src/common/xassert.h"
 
 /* closeall FDs >= a specified value */
@@ -158,7 +157,6 @@ create_pidfile(const char *pidfile)
 	xassert(pidfile != NULL);
 	xassert(pidfile[0] == '/');
 
-	(void) mkdir_parent(pidfile, 0755);
 	if (!(fp = fopen(pidfile, "w"))) {
 		error("Unable to open pidfile `%s': %m", pidfile);
 		return -1;

src/common/log.c

@@ -183,7 +183,6 @@ _log_init(char *prog, log_options_t opt, log_facility_t fac, char *logfile )
 	if (logfile && (log->opt.logfile_level > LOG_LEVEL_QUIET)) {
 		FILE *fp; 
 
-		(void) mkdir_parent(logfile, 0700);
 		fp = safeopen(logfile, "a", SAFEOPEN_LINK_OK);
 
 		if (!fp) {

src/common/safeopen.c

@@ -58,36 +58,3 @@ FILE * safeopen(const char *path, const char *mode, int flags)
 
 }
 
-int
-mkdir_parent(const char *path_name, mode_t mode)
-{
-	char *dir_path, *tmp_ptr;
-	int i, rc = 0;
-
-	xassert(path_name);
-	xassert(path_name[0] == '/');
-
-	/* copy filename and strip off final element */
-	dir_path = xstrdup(path_name);
-	tmp_ptr  = strrchr(dir_path, (int)'/');
-	tmp_ptr[0] = (char) 0;
-
-	/* now create the parent directories */
-	for (i=1; ; i++) {
-		if (dir_path[i] == (char) 0) {
-			if (mkdir(dir_path, mode) && (errno != EEXIST))
-				rc = -1;
-			break;
-		}
-		if (dir_path[i] == '/') {
-			dir_path[i] = (char) 0;
-			if (mkdir(dir_path, mode) && (errno != EEXIST))
-				rc = -1;
-			dir_path[i] = '/';
-		}
-	}
-
-	xfree(dir_path);
-	return rc;
-}
-

src/common/safeopen.h

@@ -24,14 +24,4 @@
  */
 FILE *safeopen(const char *path, const char *mode, int flags);
 
-/*
- * create parent directories as needed so that a specified 
- * file or directory can later be create
- * path_name IN - path name of the file or directory to be later 
- *                created, only its parents are created
- * mode IN      - permission mode to be used in creating directories
- * RET          - zero on success, -1 on failure with errno set
- */
-extern int mkdir_parent(const char *path_name, mode_t mode);
-
 #endif /* _SAFEOPEN_H */