Remove defunct job step pack functions.

src/slurmctld/slurmctld.h

@@ -381,13 +381,6 @@ extern void pack_ctld_job_step_info( struct  step_record* step, void **buf_ptr,
  */
 extern void pack_all_part (char **buffer_ptr, int *buffer_size, time_t * update_time);
 
-/* 
- * pack_all_step - dump all job step information for all steps in 
- *	machine independent form (for network transmission)
- * NOTE: the caller must xfree the buffer at *buffer_ptr when no longer required
- */
-extern void pack_all_step (char **buffer_ptr, int *buffer_size, time_t * update_time);
-
 /* 
  * pack_job - dump all configuration information about a specific job in 
  *	machine independent form (for network transmission)
@@ -405,12 +398,6 @@ extern void pack_node (struct node_record *dump_node_ptr, void **buf_ptr, int *b
  */
 extern void pack_part (struct part_record *part_record_point, void **buf_ptr, int *buf_len);
 
-/* 
- * pack_step - dump state information about a specific job step in 
- *	machine independent form (for network transmission)
- */
-extern void pack_step (struct step_record *dump_step_ptr, void **buf_ptr, int *buf_len);
-
 /*
  * purge_old_job - purge old job records. if memory space is needed. 
  *	the jobs must have completed at least MIN_JOB_AGE minutes ago

src/slurmctld/step_mgr.c

@@ -179,122 +179,6 @@ find_step_record(struct job_record *job_ptr, uint16_t step_id)
 }
 
 
-/* 
- * pack_all_steps - for a specifiied job dump all step information in 
- *	machine independent form (for network transmission)
- * input:  job_ptr - pointer to job for which step info is requested
- *         buffer_ptr - location into which a pointer to the data is to be stored.
- *                     the calling function must xfree the storage.
- *         buffer_size - location into which the size of the created buffer is in bytes
- *         update_time - dump new data only if partition records updated since time 
- *                       specified, otherwise return empty buffer
- * output: buffer_ptr - the pointer is set to the allocated buffer.
- *         buffer_size - set to size of the buffer in bytes
- *         update_time - set to time partition records last updated
- * NOTE: the buffer at *buffer_ptr must be xfreed by the caller
- * NOTE: change unpack_step_desc() in common/slurm_protocol_pack.c whenever the
- *	data format changes
- */
-void 
-pack_all_steps (struct job_record *job_ptr, char **buffer_ptr, int *buffer_size, time_t * update_time) 
-{
-	ListIterator step_record_iterator;
-	struct step_record *step_record_point;
-	int buf_len, buffer_allocated, buffer_offset = 0;
-	char *buffer;
-	void *buf_ptr;
-	uint32_t steps_packed ;
-
-	buffer_ptr[0] = NULL;
-	*buffer_size = 0;
-
-	buffer_allocated = (BUF_SIZE*16);
-	buffer = xmalloc(buffer_allocated);
-	buf_ptr = buffer;
-	buf_len = buffer_allocated;
-
-	/* write message body header : size only */
-	/* put in a place holder job record count of 0 for now */
-	steps_packed = 0 ;
-	pack32  ((uint32_t) steps_packed, &buf_ptr, &buf_len);
-
-	/* write individual job step records */
-	step_record_iterator = list_iterator_create (job_ptr->step_list);		
-	while ((step_record_point = 
-		(struct step_record *) list_next (step_record_iterator))) {
-
-		pack_step (step_record_point, &buf_ptr, &buf_len);
-		if (buf_len > BUF_SIZE) {
-			steps_packed ++ ;
-			continue;
-		}
-		buffer_allocated += (BUF_SIZE*16);
-		buf_len += (BUF_SIZE*16);
-		buffer_offset = (char *)buf_ptr - buffer;
-		xrealloc(buffer, buffer_allocated);
-		buf_ptr = buffer + buffer_offset;
-	}			
-
-	list_iterator_destroy (step_record_iterator);
-	buffer_offset = (char *)buf_ptr - buffer;
-	xrealloc (buffer, buffer_offset);
-
-	buffer_ptr[0] = buffer;
-	*buffer_size = buffer_offset;
-
-	/* put the real record count in the message body header */	
-	buf_ptr = buffer;
-	buf_len = buffer_allocated;
-	pack32  ((uint32_t) steps_packed, &buf_ptr, &buf_len);
-}
-
-
-/* 
- * pack_step - dump state information about a specific job step in 
- *	machine independent form (for network transmission)
- * input:  dump_step_ptr - pointer to step for which information is requested
- *	buf_ptr - buffer for step information 
- *	buf_len - byte size of buffer
- * output: buf_ptr - advanced to end of data written
- *	buf_len - byte size remaining in buffer
- *	return 0 if no error, 1 if buffer too small
- * NOTE: change STEP_STRUCT_VERSION in common/slurmlib.h whenever the format changes
- * NOTE: change slurm_load_step() in api/step_info.c whenever the data format changes
- * NOTE: the caller must insure that the buffer is sufficiently large to hold 
- *	 the data being written (space remaining at least BUF_SIZE)
- */
-void 
-pack_step (struct step_record *dump_step_ptr, void **buf_ptr, int *buf_len) 
-{
-#ifdef HAVE_LIBELAN3
-	int len;
-#endif
-	char node_inx_ptr[BUF_SIZE];
-
-
-	pack16  (dump_step_ptr->step_id, buf_ptr, buf_len);
-
-	if (dump_step_ptr->node_bitmap) {
-		bit_fmt (node_inx_ptr, BUF_SIZE, dump_step_ptr->node_bitmap);
-		packstr (node_inx_ptr, buf_ptr, buf_len);
-	}
-	else
-		packstr ("", buf_ptr, buf_len);
-
-#ifdef HAVE_LIBELAN3
-	if (dump_step_ptr->qsw_job) {
-		len = qsw_pack_jobinfo (dump_step_ptr->qsw_job, *buf_ptr, *buf_len);
-		if (len > 0) {		/* Need to explicitly advance pointer and index here */
-			*buf_ptr = (void *) ((char *)*buf_ptr + len);
-			*buf_len += len;
-		}
-	}
-	else
-		packstr (NULL, buf_ptr, buf_len);
-#endif
-}
-
-
 /* 
  * pick_step_nodes - select nodes for a job step that satify its requirements
  *	we satify the super-set of constraints.