Remove vestigial function

Its logic was flawed (lacked a level of indirection) as reported
by CLANG and was not used anyway.

src/common/slurm_protocol_api.c

@@ -2632,18 +2632,6 @@ slurm_fd_t slurm_open_controller_conn_spec(enum controller_id dest)
 	return rc;
 }
 
-/* gets the slurm_addr_t of the specified controller
- *	primary or secondary slurmctld message engine
- * IN dest      - controller to contact, primary or secondary
- * OUT addr     - slurm_addr_t to the specified controller
- */
-void slurm_get_controller_addr_spec(enum controller_id dest, slurm_addr_t *addr)
-{
-	addr = (dest == PRIMARY_CONTROLLER) ?
-		&proto_conf->primary_controller :
-		&proto_conf->secondary_controller;
-}
-
 /* In the bsd implmentation maps directly to a close call, to close
  *	the socket that was accepted
  * IN open_fd		- an open file descriptor to close

src/common/slurm_protocol_api.h

@@ -923,13 +923,6 @@ int slurm_send_node_msg(slurm_fd_t open_fd, slurm_msg_t *msg);
  */
 extern slurm_fd_t slurm_open_controller_conn(slurm_addr_t *addr);
 extern slurm_fd_t slurm_open_controller_conn_spec(enum controller_id dest);
-/* gets the slurm_addr_t of the specified controller
- *	primary or secondary slurmctld message engine
- * IN dest      - controller to contact, primary or secondary
- * OUT addr     - slurm_addr_t to the specified controller
- */
-void slurm_get_controller_addr_spec(enum controller_id dest,
-				    slurm_addr_t *addr);
 
 /* In the bsd socket implementation it creates a SOCK_STREAM socket
  *	and calls connect on it a SOCK_DGRAM socket called with connect