From f9db5e9ff974868d6899c2ce88fcbe7021a00243 Mon Sep 17 00:00:00 2001
From: Morris Jette <jette@schedmd.com>
Date: Wed, 4 Sep 2013 15:56:45 -0700
Subject: [PATCH] Prevent possible uninitialized variable use
Fix problem reported by CLANG
bug 403
---
src/slurmd/slurmstepd/req.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/src/slurmd/slurmstepd/req.c b/src/slurmd/slurmstepd/req.c
index 4f3e4b2018d..7f84c8ca82b 100644
--- a/src/slurmd/slurmstepd/req.c
+++ b/src/slurmd/slurmstepd/req.c
@@ -1103,9 +1103,14 @@ done:
xfree(gtids);
for (i = 0; i < job->node_tasks; i++) {
- len = strlen(job->task[i]->argv[0]) + 1;
- safe_write(fd, &len, sizeof(int));
- safe_write(fd, job->task[i]->argv[0], len);
+ if (job->task[i] && job->task[i]->argv) {
+ len = strlen(job->task[i]->argv[0]) + 1;
+ safe_write(fd, &len, sizeof(int));
+ safe_write(fd, job->task[i]->argv[0], len);
+ } else {
+ len = 0;
+ safe_write(fd, &len, sizeof(int));
+ }
}
}
--
GitLab