From e4a0fe684b8af1c63fe492aa82df5fdab7d69979 Mon Sep 17 00:00:00 2001
From: Morris Jette <jette@schedmd.com>
Date: Tue, 23 Jan 2018 17:36:50 -0700
Subject: [PATCH] Fix for possible NULL pointer reference
Coverity CID 182335
---
src/common/proc_args.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/common/proc_args.c b/src/common/proc_args.c
index abba5277ce3..0b340c68619 100644
--- a/src/common/proc_args.c
+++ b/src/common/proc_args.c
@@ -1848,10 +1848,14 @@ uint16_t parse_compress_type(const char *arg)
extern int validate_acctg_freq(char *acctg_freq)
{
int i;
- char *save_ptr = NULL, *tok, *tmp = xstrdup(optarg);
+ char *save_ptr = NULL, *tok, *tmp;
bool valid;
int rc = SLURM_SUCCESS;
+ if (!optarg)
+ return rc;
+
+ tmp = xstrdup(optarg);
tok = strtok_r(tmp, ",", &save_ptr);
while (tok) {
valid = false;
--
GitLab