From db599fa58d6597c77997ece32f34e555d059235d Mon Sep 17 00:00:00 2001
From: Tim Wickberg <tim@schedmd.com>
Date: Thu, 14 Apr 2016 13:32:42 -0400
Subject: [PATCH] Remove extraneous null check to silence Coverity warning.
step_ptr->job_ptr is already dereferenced several times by now, so
null check is unnecessary here.
---
src/plugins/select/cray/select_cray.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/plugins/select/cray/select_cray.c b/src/plugins/select/cray/select_cray.c
index c4502e15619..8969113ffdc 100644
--- a/src/plugins/select/cray/select_cray.c
+++ b/src/plugins/select/cray/select_cray.c
@@ -1196,10 +1196,9 @@ static void *_step_kill(void *args)
nhc_info.exit_code = SIGKILL;
nhc_info.user_id = step_ptr->job_ptr->user_id;
- if (!step_ptr->step_layout || !step_ptr->step_layout->node_list) {
- if (step_ptr->job_ptr)
- nhc_info.nodelist = xstrdup(step_ptr->job_ptr->nodes);
- } else
+ if (!step_ptr->step_layout || !step_ptr->step_layout->node_list)
+ nhc_info.nodelist = xstrdup(step_ptr->job_ptr->nodes);
+ else
nhc_info.nodelist = xstrdup(step_ptr->step_layout->node_list);
unlock_slurmctld(job_read_lock);
--
GitLab