From d939bab8e5c73157c94583befec4aab59a196e47 Mon Sep 17 00:00:00 2001
From: Moe Jette <jette1@llnl.gov>
Date: Fri, 5 May 2006 22:25:35 +0000
Subject: [PATCH] Fix memory leak.
---
src/slurmctld/proc_req.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/slurmctld/proc_req.c b/src/slurmctld/proc_req.c
index d1de8a70f91..37d2e972442 100644
--- a/src/slurmctld/proc_req.c
+++ b/src/slurmctld/proc_req.c
@@ -416,10 +416,13 @@ static int _make_step_cred(struct step_record *step_rec,
cred_arg.ntask = xmalloc(cred_arg.ntask_cnt * sizeof(int));
memcpy(cred_arg.ntask, step_rec->job_ptr->ntask,
cred_arg.ntask_cnt*sizeof(int));
- }
+ } else
+ cred_arg.ntask = NULL;
- if ( (*slurm_cred = slurm_cred_create(slurmctld_config.cred_ctx,
- &cred_arg)) == NULL) {
+ *slurm_cred = slurm_cred_create(slurmctld_config.cred_ctx,
+ &cred_arg);
+ xfree(cred_arg.ntask);
+ if (*slurm_cred == NULL) {
error("slurm_cred_create error");
return ESLURM_INVALID_JOB_CREDENTIAL;
}
--
GitLab