From c5d764c56373c6699b6d7676ba6bdaedad43499a Mon Sep 17 00:00:00 2001
From: Tim Wickberg <tim@schedmd.com>
Date: Mon, 28 Nov 2016 15:08:04 -0500
Subject: [PATCH] mcs/account plugin - avoid unnecessary string copy.
---
src/plugins/mcs/account/mcs_account.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/plugins/mcs/account/mcs_account.c b/src/plugins/mcs/account/mcs_account.c
index 3bd6a1bc8df..4aaf701b456 100644
--- a/src/plugins/mcs/account/mcs_account.c
+++ b/src/plugins/mcs/account/mcs_account.c
@@ -96,14 +96,12 @@ extern int fini(void)
*/
extern int mcs_p_set_mcs_label(struct job_record *job_ptr, char *label)
{
- char *account = NULL;
int rc = SLURM_SUCCESS;
- account = xstrdup(job_ptr->account);
xfree(job_ptr->mcs_label);
if (label != NULL) {
/* test label param */
- if (xstrcmp(label, account) == 0) {
- job_ptr->mcs_label = xstrdup(account);
+ if (!xstrcmp(label, job_ptr->account)) {
+ job_ptr->mcs_label = xstrdup(job_ptr->account);
} else {
rc = SLURM_ERROR;
}
@@ -112,10 +110,9 @@ extern int mcs_p_set_mcs_label(struct job_record *job_ptr, char *label)
(job_ptr->details->whole_node != WHOLE_NODE_MCS)) {
;
} else {
- job_ptr->mcs_label = xstrdup(account);
+ job_ptr->mcs_label = xstrdup(job_ptr->account);
}
}
- xfree(account);
return rc;
}
--
GitLab