diff --git a/NEWS b/NEWS index b137a4f79e0ad0f0903939989dd5d5b5455bed63..cb2e2f19aae9b5258e70f8e48936b6b58a8dd5ce 100644 --- a/NEWS +++ b/NEWS @@ -78,7 +78,6 @@ documents those changes that are of interest to users and administrators. -- Make logging prefix for slurmstepd to happen as soon as possible. -- mpi/pmix: Fix the job registration for the PMIx v2.1. -- Fix uid check for signaling a step with anything but SIGKILL. - -- Fix uid check when requesting a jobid from a pid. -- Return ESLURM_TRANSITION_STATE_NO_UPDATE instead of EAGAIN when trying to signal a step that is still running a prolog. -- Update Cray slurm_playbook.yaml with latest recommended version. diff --git a/src/slurmd/slurmd/req.c b/src/slurmd/slurmd/req.c index 7c838fa42c99e2dde4009302cdac5e346a767cdb..9d340503649e00dd4ba4235dfcac3251ddacfa2f 100644 --- a/src/slurmd/slurmd/req.c +++ b/src/slurmd/slurmd/req.c @@ -3861,15 +3861,9 @@ static void _rpc_pid2jid(slurm_msg_t *msg) slurm_msg_t resp_msg; job_id_response_msg_t resp; bool found = false; - bool auth = false; List steps; ListIterator i; step_loc_t *stepd; - uid_t req_uid; - - req_uid = g_slurm_auth_get_uid(msg->auth_cred, conf->auth_info); - if (_slurm_authorized_user(req_uid)) - auth = true; steps = stepd_available(conf->spooldir, conf->node_name); i = list_iterator_create(steps); @@ -3880,13 +3874,7 @@ static void _rpc_pid2jid(slurm_msg_t *msg) &stepd->protocol_version); if (fd == -1) continue; - if (!auth && - (stepd_get_uid(fd, stepd->protocol_version) != req_uid)) { - close(fd); - debug3("%s: REQUEST_JOB_ID from uid=%d but they aren't the owner of job %u", - __func__, req_uid, stepd->jobid); - continue; - } + if (stepd_pid_in_container( fd, stepd->protocol_version, req->job_pid)