From b91d28dbe0f3af9ee46f6fbe6acd2962e6896ae6 Mon Sep 17 00:00:00 2001
From: Brian Christiansen <brian@schedmd.com>
Date: Mon, 2 May 2016 11:34:54 -0700
Subject: [PATCH] Update logic
Had:
if (specname && otherstuff) {
} if (specname) {
}
---
src/slurmctld/job_mgr.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/slurmctld/job_mgr.c b/src/slurmctld/job_mgr.c
index 8498c46536f..f396e5ff630 100644
--- a/src/slurmctld/job_mgr.c
+++ b/src/slurmctld/job_mgr.c
@@ -11287,14 +11287,13 @@ static int _update_job(struct job_record *job_ptr, job_desc_msg_t * job_specs,
assoc_mgr_unlock(&locks);
}
- if (job_specs->name
- && !xstrcmp(job_specs->name, job_ptr->name)) {
- debug("sched: update_job: new name identical to "
- "old name %u", job_ptr->job_id);
- } if (job_specs->name) {
+ if (job_specs->name) {
if (IS_JOB_FINISHED(job_ptr)) {
error_code = ESLURM_JOB_FINISHED;
goto fini;
+ } else if (!xstrcmp(job_specs->name, job_ptr->name)) {
+ debug("sched: update_job: new name identical to "
+ "old name %u", job_ptr->job_id);
} else {
xfree(job_ptr->name);
job_ptr->name = xstrdup(job_specs->name);
--
GitLab