From b0b81690f17ee22c0c879eaf21a5a88e65efd6b5 Mon Sep 17 00:00:00 2001
From: Tim Wickberg <tim@schedmd.com>
Date: Sat, 11 Jun 2016 02:24:13 +0200
Subject: [PATCH] Start strncpy -> strlcpy cleanup.

strlcpy ensures strings are terminated with \0 properly.
---
 src/plugins/mpi/pmi2/info.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/plugins/mpi/pmi2/info.c b/src/plugins/mpi/pmi2/info.c
index 459485d8065..5e101ba6f5d 100644
--- a/src/plugins/mpi/pmi2/info.c
+++ b/src/plugins/mpi/pmi2/info.c
@@ -51,6 +51,7 @@
 #include <unistd.h>
 #include "slurm/slurm.h"
 #include "src/srun/libsrun/launch.h"
+#include "src/common/strlcpy.h"
 #include "src/common/switch.h"
 #include "src/common/slurm_protocol_api.h"
 #include "src/common/xmalloc.h"
@@ -84,7 +85,7 @@ enqueue_nag_req(int fd, int rank, char *key)
 	req = xmalloc(sizeof(nag_req_t));
 	req->fd = fd;
 	req->rank = rank;
-	strncpy(req->key, key, (PMI2_MAX_KEYLEN - 1));	/* Insure NULL at end */
+	strlcpy(req->key, key, PMI2_MAX_KEYLEN);
 
 	/* insert in the head */
 	req->next = nag_req_list;
-- 
GitLab