diff --git a/NEWS b/NEWS index 53fdf4a58a6b420f9edfab1d44689537c0a29bed..6f89865d563bd1c05f9328a3ee1127df1cfaae8f 100644 --- a/NEWS +++ b/NEWS @@ -35,6 +35,8 @@ documents those changes that are of interest to users and admins. management yet. -- For srun/sbatch --get-user-env option (Moab use only) look for "env" command in both /bin and /usr/sbin (for Suse Linux). + -- Fix bug in processing job feature requests with node counts (could fail + to schedule job if some nodes have not associated features). * Changes in SLURM 1.3.1 ======================== diff --git a/src/slurmctld/node_scheduler.c b/src/slurmctld/node_scheduler.c index 366f308be43e7986904d2dacd783c2c42fe674e1..d6ea15e892d16efd6a398af51ff3744d0c19a887 100644 --- a/src/slurmctld/node_scheduler.c +++ b/src/slurmctld/node_scheduler.c @@ -233,7 +233,7 @@ static int _match_feature(char *seek, char *available) if (seek == NULL) return 1; /* nothing to look for */ if (available == NULL) - return SLURM_SUCCESS; /* nothing to find */ + return 0; /* nothing to find */ tmp_available = xstrdup(available); found = 0; @@ -1636,8 +1636,6 @@ static bitstr_t *_valid_features(struct job_details *details_ptr, bit_set(result_bits, 0); return result_bits; } - if (available == NULL) /* no features */ - return result_bits; result = 1; /* assume good for now */ last_op = FEATURE_OP_AND;