diff --git a/src/slurmctld/read_config.c b/src/slurmctld/read_config.c index 5b5951bb7f693ac83ee33567dd0c72c8e0af4208..20081a5f6490c3d7a15d1613095a944fa101cb6b 100644 --- a/src/slurmctld/read_config.c +++ b/src/slurmctld/read_config.c @@ -923,7 +923,7 @@ int read_slurm_conf(int recover, bool reconfig) } else { load_all_resv_state(recover); if (recover >= 1) { - (void) trigger_state_restore(); + trigger_state_restore(); (void) slurm_sched_reconfig(); } } diff --git a/src/slurmctld/trigger_mgr.c b/src/slurmctld/trigger_mgr.c index 412001d591a45cc729b28e773e7bf64be4c73c16..470dd00a8362c939212fbc64f0bcb79e6de79348 100644 --- a/src/slurmctld/trigger_mgr.c +++ b/src/slurmctld/trigger_mgr.c @@ -883,9 +883,9 @@ static int _open_resv_state_file(char **state_file) return state_fd; } -extern int trigger_state_restore(void) +extern void trigger_state_restore(void) { - int data_allocated, data_read = 0, error_code = 0; + int data_allocated, data_read = 0; uint32_t data_size = 0; uint16_t protocol_version = (uint16_t) NO_VAL; int state_fd, trigger_cnt = 0; @@ -900,7 +900,6 @@ extern int trigger_state_restore(void) state_fd = _open_resv_state_file(&state_file); if (state_fd < 0) { info("No trigger state file (%s) to recover", state_file); - error_code = ENOENT; } else { data_allocated = BUF_SIZE; data = xmalloc(data_allocated); @@ -940,7 +939,7 @@ extern int trigger_state_restore(void) "incompatible"); xfree(ver_str); free_buf(buffer); - return EFAULT; + return; } xfree(ver_str); @@ -948,8 +947,8 @@ extern int trigger_state_restore(void) if (trigger_list) list_delete_all (trigger_list, _match_all_triggers, NULL); while (remaining_buf(buffer) > 0) { - error_code = _load_trigger_state(buffer, protocol_version); - if (error_code != SLURM_SUCCESS) + if (_load_trigger_state(buffer, protocol_version) != + SLURM_SUCCESS) goto unpack_error; trigger_cnt++; } @@ -959,7 +958,6 @@ unpack_error: error("Incomplete trigger data checkpoint file"); fini: verbose("State of %d triggers recovered", trigger_cnt); free_buf(buffer); - return SLURM_FAILURE; } static bool _front_end_job_test(bitstr_t *front_end_bitmap, @@ -987,7 +985,7 @@ static void _trigger_job_event(trig_mgr_info_t *trig_in, time_t now) if ((trig_in->job_ptr == NULL) || (trig_in->job_ptr->magic != JOB_MAGIC) || (trig_in->job_ptr->job_id != trig_in->job_id)) - trig_in->job_ptr = find_job_record(trig_in->job_ptr->job_id); + trig_in->job_ptr = find_job_record(trig_in->job_id); if ((trig_in->trig_type & TRIGGER_TYPE_FINI) && ((trig_in->job_ptr == NULL) || @@ -996,7 +994,7 @@ static void _trigger_job_event(trig_mgr_info_t *trig_in, time_t now) trig_in->trig_time = now + (trig_in->trig_time - 0x8000); if (slurm_get_debug_flags() & DEBUG_FLAG_TRIGGERS) { info("trigger[%u] event for job %u fini", - trig_in->trig_id, trig_in->job_id); + trig_in->trig_id, trig_in->job_ptr->job_id); } return; } diff --git a/src/slurmctld/trigger_mgr.h b/src/slurmctld/trigger_mgr.h index 1686d94f1271e0eeb73f3e865f62b6a24c273513..faa9436616b32117930e05d58d484923670c71e7 100644 --- a/src/slurmctld/trigger_mgr.h +++ b/src/slurmctld/trigger_mgr.h @@ -75,7 +75,7 @@ extern void trigger_primary_db_res_op(void); /* Save and restore state for slurmctld fail-over or restart */ extern int trigger_state_save(void); -extern int trigger_state_restore(void); +extern void trigger_state_restore(void); /* Free all allocated memory */ extern void trigger_fini(void);