From 950b9b59fb4a579fe79695b5c025c8aaf28efade Mon Sep 17 00:00:00 2001
From: Brian Christiansen <brian@schedmd.com>
Date: Mon, 28 Aug 2017 14:57:17 -0600
Subject: [PATCH] Handle gcc "ignoring return value" warning
reported when compiling with optimizations (-O2).
---
src/slurmctld/controller.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/slurmctld/controller.c b/src/slurmctld/controller.c
index 711f8f784f1..e88fdf7dae2 100644
--- a/src/slurmctld/controller.c
+++ b/src/slurmctld/controller.c
@@ -2620,7 +2620,7 @@ static bool _verify_clustername(void)
{
FILE *fp;
char *filename = NULL;
- char name[512];
+ char name[512] = {0};
bool create_file = false;
xstrfmtcat(filename, "%s/clustername",
@@ -2628,7 +2628,10 @@ static bool _verify_clustername(void)
if ((fp = fopen(filename, "r"))) {
/* read value and compare */
- fgets(name, sizeof(name), fp);
+ if (!fgets(name, sizeof(name), fp)) {
+ error("%s: reading cluster name from clustername file",
+ __func__);
+ }
fclose(fp);
if (xstrcmp(name, slurmctld_conf.cluster_name)) {
fatal("CLUSTER NAME MISMATCH.\n"
--
GitLab