From 6f12156e047ae11a1203c4160f28bbad281c7b8d Mon Sep 17 00:00:00 2001
From: Morris Jette <jette@schedmd.com>
Date: Mon, 9 Sep 2013 10:31:36 -0700
Subject: [PATCH] Add more job array error logging
---
src/slurmctld/job_mgr.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/src/slurmctld/job_mgr.c b/src/slurmctld/job_mgr.c
index 92a9e8cf655..9104986c34b 100644
--- a/src/slurmctld/job_mgr.c
+++ b/src/slurmctld/job_mgr.c
@@ -4483,8 +4483,10 @@ static bool _valid_array_inx(job_desc_msg_t *job_desc)
conf = slurm_conf_lock();
max_array_size = conf->max_array_sz;
slurm_conf_unlock();
- if (max_array_size == 0)
+ if (max_array_size == 0) {
+ verbose("Job arrays disabled, MaxArraySize=0");
return false;
+ }
/* We have a job array request */
job_desc->immediate = 0; /* Disable immediate option */
@@ -4502,11 +4504,14 @@ static bool _valid_array_inx(job_desc_msg_t *job_desc)
}
hs = hostset_create(array_str);
xfree(array_str);
- if (!hs)
+ if (!hs) {
+ verbose("Invalid job array string (%s)", array_str);
return false;
+ }
array_str = hostset_shift(hs);
if (!array_str) {
hostset_destroy(hs);
+ verbose("Invalid job array string (%s)", array_str);
return false;
}
@@ -4516,6 +4521,8 @@ static bool _valid_array_inx(job_desc_msg_t *job_desc)
if ((array_str[0] == '\0') || (end_ptr[0] != '\0') ||
(array_id < 0) || (array_id >= max_array_size)) {
valid = false;
+ verbose("Invalid job array element value (%d)",
+ array_id);
}
free(array_str);
if (!valid)
@@ -4524,8 +4531,10 @@ static bool _valid_array_inx(job_desc_msg_t *job_desc)
array_str = hostset_shift(hs);
}
hostset_destroy(hs);
- if (valid && (bit_set_count(job_desc->array_bitmap) == 0))
+ if (valid && (bit_set_count(job_desc->array_bitmap) == 0)) {
valid = false;
+ verbose("Job array has no elements");
+ }
if (valid && (step > 1)) {
int i, j = 0;
--
GitLab