diff --git a/NEWS b/NEWS index bad201544bfb04c516a87cc6a26a8ffc45d5a726..16d6afe7e43f1c0d2546908aefea993c650d7a4e 100644 --- a/NEWS +++ b/NEWS @@ -20,6 +20,7 @@ documents those changes that are of interest to users and admins. -- JobAcct plugin renamed from "log" to "linux" in preparation for support of new system types. WARNING: "JobAcctType=jobacct/log" is no longer supported. + -- removed vestigal 'bg' names from bluegene plugin and smap * Changes in SLURM 1.1.0-pre2 ============================= diff --git a/src/plugins/select/bluegene/plugin/state_test.c b/src/plugins/select/bluegene/plugin/state_test.c index 314d2c128ee5800c9d3e58dd9e72cc15afd4899b..1b4b53ae49b574e009691501fca62113eef67ab9 100644 --- a/src/plugins/select/bluegene/plugin/state_test.c +++ b/src/plugins/select/bluegene/plugin/state_test.c @@ -125,8 +125,12 @@ static void _configure_node_down(rm_bp_id_t bp_id, rm_BGL_t *bg) error("rm_get_data(RM_BPLoc): %s", bg_err_str(rc)); continue; } - snprintf(bg_down_node, sizeof(bg_down_node), "bg%d%d%d", + slurm_conf_lock(); + snprintf(bg_down_node, sizeof(bg_down_node), "%s%d%d%d", + slurmctld_conf.node_prefix, bp_loc.X, bp_loc.Y, bp_loc.Z); + slurm_conf_unlock(); + if (node_already_down(bg_down_node)) break; @@ -213,9 +217,12 @@ static void _test_down_nodes(rm_BGL_t *bg) continue; } - snprintf(bg_down_node, sizeof(bg_down_node), "bg%d%d%d", + slurm_conf_lock(); + snprintf(bg_down_node, sizeof(bg_down_node), "%s%d%d%d", + slurmctld_conf.node_prefix, bp_loc.X, bp_loc.Y, bp_loc.Z); - + slurm_conf_unlock(); + if (node_already_down(bg_down_node)) continue; diff --git a/src/slurmctld/read_config.c b/src/slurmctld/read_config.c index 2b7aa3242b3257ee4d7de1d5abfdabc5108c3658..92a687306f5b8b5bc412178bbc5ca6a8ad758552 100644 --- a/src/slurmctld/read_config.c +++ b/src/slurmctld/read_config.c @@ -252,6 +252,7 @@ static int _init_all_slurm_conf(void) char *conf_name = xstrdup(slurmctld_conf.slurm_conf); slurm_conf_reinit(conf_name); + xfree(conf_name); if ((error_code = init_node_conf())) return error_code; diff --git a/src/smap/configure_functions.c b/src/smap/configure_functions.c index fb453354700ef7d2b1e74e4e88abcb99879cef5f..c9146903058272385a7dc00dd0b9a1ba40175142 100644 --- a/src/smap/configure_functions.c +++ b/src/smap/configure_functions.c @@ -433,9 +433,8 @@ static int _resolve(char *com) if(coord) sprintf(error_string, - "%s resolves to X=%d Y=%d Z=%d or bg%d%d%d\n", - com+i,coord[X],coord[Y],coord[Z], - coord[X],coord[Y],coord[Z]); + "%s resolves to X=%d Y=%d Z=%d\n", + com+i,coord[X],coord[Y],coord[Z]); else sprintf(error_string, "%s has no resolve.\n", com+i); diff --git a/src/smap/smap.c b/src/smap/smap.c index 22fb693d961d28750207437d65589eec480b795b..9f3a17caa9cc09f05c6343f12bf7f1e94f995435 100644 --- a/src/smap/smap.c +++ b/src/smap/smap.c @@ -73,7 +73,7 @@ int main(int argc, char *argv[]) int mapset = 0; #endif //char *name; - + log_init(xbasename(argv[0]), opts, SYSLOG_FACILITY_DAEMON, NULL); parse_command_line(argc, argv); while (slurm_load_node((time_t) NULL, &new_node_ptr, SHOW_ALL)) { @@ -88,10 +88,8 @@ int main(int argc, char *argv[]) sleep(10); /* keep trying to reconnect */ } - printf("starting\n"); ba_init(new_node_ptr); - printf("done hey\n"); - + if(params.partition) { #ifdef HAVE_BG_FILES @@ -127,9 +125,10 @@ int main(int argc, char *argv[]) } else { int *coord = find_bp_loc(params.partition); if(coord) - printf("%s resolves to X=%d Y=%d Z=%d or bg%d%d%d\n", + printf("%s resolves to X=%d Y=%d Z=%d\n", params.partition, coord[X], coord[Y], coord[Z], + slurmctld_conf.node_prefix, coord[X], coord[Y], coord[Z]); else printf("%s has no resolve.\n",