From 5fd3b29c06e64948a293b53c71e6ac30d5d2abb6 Mon Sep 17 00:00:00 2001
From: Danny Auble <da@schedmd.com>
Date: Wed, 28 Dec 2011 12:13:02 -0800
Subject: [PATCH] BLUEGENE - push out create procedure into a function for
 making a subgrp in a midplane.

---
 src/plugins/select/bluegene/bg_node_info.c | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/src/plugins/select/bluegene/bg_node_info.c b/src/plugins/select/bluegene/bg_node_info.c
index 226677af4be..13911630b26 100644
--- a/src/plugins/select/bluegene/bg_node_info.c
+++ b/src/plugins/select/bluegene/bg_node_info.c
@@ -54,6 +54,17 @@ static void _free_node_subgrp(void *object)
 	}
 }
 
+static node_subgrp_t *_create_subgrp(List subgrp_list, enum node_states state,
+				     uint16_t size)
+{
+	node_subgrp_t *subgrp = xmalloc(sizeof(node_subgrp_t));
+	subgrp->state = state;
+	subgrp->bitmap = bit_alloc(size);
+	list_append(subgrp_list, subgrp);
+
+	return subgrp;
+}
+
 static node_subgrp_t *_find_subgrp(List subgrp_list, enum node_states state,
 				   uint16_t size)
 {
@@ -66,12 +77,9 @@ static node_subgrp_t *_find_subgrp(List subgrp_list, enum node_states state,
 			break;
 	}
 	list_iterator_destroy(itr);
-	if (!subgrp) {
-		subgrp = xmalloc(sizeof(node_subgrp_t));
-		subgrp->state = state;
-		subgrp->bitmap = bit_alloc(size);
-		list_append(subgrp_list, subgrp);
-	}
+
+	if (!subgrp)
+		subgrp = _create_subgrp(subgrp_list, state, size);
 
 	return subgrp;
 }
-- 
GitLab