From 4dd9839ccb66189a4ce20f4be7437bd1dd68545d Mon Sep 17 00:00:00 2001
From: Morris Jette <jette@schedmd.com>
Date: Wed, 4 Sep 2013 15:53:14 -0700
Subject: [PATCH] Prevent uninitialized variable
Reported by CLANG, but not possible in practice
bug 403
---
src/slurmctld/controller.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/slurmctld/controller.c b/src/slurmctld/controller.c
index 0abdb243174..583c6c5ce46 100644
--- a/src/slurmctld/controller.c
+++ b/src/slurmctld/controller.c
@@ -239,7 +239,7 @@ int main(int argc, char *argv[])
slurmctld_lock_t config_write_lock = {
WRITE_LOCK, WRITE_LOCK, WRITE_LOCK, WRITE_LOCK };
assoc_init_args_t assoc_init_arg;
- pthread_t assoc_cache_thread;
+ pthread_t assoc_cache_thread = (pthread_t) 0;
slurm_trigger_callbacks_t callbacks;
char *dir_name;
@@ -911,6 +911,8 @@ static void *_slurmctld_rpc_mgr(void *no_data)
/* initialize ports for RPCs */
lock_slurmctld(config_read_lock);
nports = slurmctld_conf.slurmctld_port_count;
+ if (nports == 0)
+ fatal("slurmctld port count is zero");
sockfd = xmalloc(sizeof(slurm_fd_t) * nports);
for (i=0; i<nports; i++) {
sockfd[i] = slurm_init_msg_engine_addrname_port(
--
GitLab