From 4715617ef6c2129dce02ad4fd5197737cc5d48e1 Mon Sep 17 00:00:00 2001
From: Mark Grondona <mgrondona@llnl.gov>
Date: Fri, 13 Sep 2002 19:21:04 +0000
Subject: [PATCH] o move list_mutex_unlock() back above list_iterator_free()
in list_iterator_destroy(). This caused a race condition where iterator
could be pointing to new list by the time list_mutex_unlock() was called.
---
src/common/list.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/common/list.c b/src/common/list.c
index 92c8c30bfdf..6ec5352d4a1 100644
--- a/src/common/list.c
+++ b/src/common/list.c
@@ -466,9 +466,9 @@ void list_iterator_destroy(ListIterator i)
break;
}
}
- assert(i->magic = ITER_DESTROYED); /* clear magic via assert abuse */
- list_iterator_free(i);
list_mutex_unlock(&i->list->mutex);
+ assert(i->magic = ITER_DESTROYED); /* clear magic via assert abuse */
+ list_iterator_free(i);
return;
}
--
GitLab