From 46d464004af761444ef72f370d2b4a0fcbaa5e5a Mon Sep 17 00:00:00 2001
From: Danny Auble <da@llnl.gov>
Date: Fri, 17 Mar 2006 00:53:06 +0000
Subject: [PATCH] segfaults on bridge api, DON'T put the bridge api verbose
over 3!!!!!! it will expose memory issues
---
src/plugins/select/bluegene/plugin/bluegene.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/plugins/select/bluegene/plugin/bluegene.c b/src/plugins/select/bluegene/plugin/bluegene.c
index f939d5ab3c5..e04c9a222f0 100644
--- a/src/plugins/select/bluegene/plugin/bluegene.c
+++ b/src/plugins/select/bluegene/plugin/bluegene.c
@@ -2682,9 +2682,8 @@ static int _reopen_bridge_log(void)
slurm_mutex_lock(&api_file_mutex);
if(fp)
fclose(fp);
- debug("got here %s", bridge_api_file);
fp = fopen(bridge_api_file, "a");
- debug("fp %d", fp);
+
if (fp == NULL) {
error("can't open file for bridgeapi.log at %s: %m",
bridge_api_file);
@@ -2693,18 +2692,17 @@ static int _reopen_bridge_log(void)
}
#ifdef HAVE_BG_FILES
- debug("hey");
setSayMessageParams(fp, bridge_api_verb);
- slurm_mutex_unlock(&api_file_mutex);
- debug("done");
#else
if (fprintf(fp, "bridgeapi.log to write here at level %d\n",
bridge_api_verb) < 20) {
error("can't write to bridgeapi.log: %m");
+ slurm_mutex_unlock(&api_file_mutex);
return SLURM_ERROR;
}
#endif
-
+ slurm_mutex_unlock(&api_file_mutex);
+
return SLURM_SUCCESS;
}
--
GitLab