diff --git a/NEWS b/NEWS index 5e222fdf8ad8fac7222877e835f9f87a6093cf4a..1506b6c5f2a0266df76e6d45927775703f8205d3 100644 --- a/NEWS +++ b/NEWS @@ -60,6 +60,7 @@ documents those changes that are of interest to users and administrators. (e.g. -C "[rack1*2&rack2*4]"). -- Fix memory leaks in preemption when jobs request multiple features. -- Allow Operator users to show/fix runaways. + -- Disallow coordinators to show/fix runaways. * Changes in Slurm 19.05.2 ========================== diff --git a/src/plugins/accounting_storage/mysql/as_mysql_fix_runaway_jobs.c b/src/plugins/accounting_storage/mysql/as_mysql_fix_runaway_jobs.c index ec21bad1af0a2f7c91dfd88050275ff40ccdd75d..088d7bfb4035a138c9631343c63f090567e56c43 100644 --- a/src/plugins/accounting_storage/mysql/as_mysql_fix_runaway_jobs.c +++ b/src/plugins/accounting_storage/mysql/as_mysql_fix_runaway_jobs.c @@ -142,18 +142,13 @@ extern int as_mysql_fix_runaway_jobs(mysql_conn_t *mysql_conn, uint32_t uid, */ mysql_conn->cluster_name = first_job->cluster; + /* + * Double check if we are at least an operator, this check should had + * already happened in the slurmdbd. + */ if (!is_user_min_admin_level(mysql_conn, uid, SLURMDB_ADMIN_OPERATOR)) { - slurmdb_user_rec_t user; - - memset(&user, 0, sizeof(slurmdb_user_rec_t)); - user.uid = uid; - - if (!is_user_any_coord(mysql_conn, &user)) { - error("Only admins/operators/coordinators " - "can fix runaway jobs"); - rc = ESLURM_ACCESS_DENIED; - goto bail; - } + rc = ESLURM_ACCESS_DENIED; + goto bail; } iter = list_iterator_create(runaway_jobs);