diff --git a/testsuite/expect/globals b/testsuite/expect/globals index bd71c9d0590eeaf4b61d193d228a72c185d1c9f3..7c7dd2f21b4907be43586eff502a75354430a4a2 100755 --- a/testsuite/expect/globals +++ b/testsuite/expect/globals @@ -555,11 +555,16 @@ proc wait_for_job { job_id desired_state } { "DONE" {} "RUNNING" {} default { - send_user "Unsupported desired state: $desired_state\n" + send_user "FAILURE: wait_for_job with invalid state: $desired_state\n" return 1 } } + if {$job_id == 0} { + send_user "FAILURE: wait_for_job with invalid job ID: $job_id\n" + return 1 + } + set sleep_time 1 set my_delay 0 while 1 { diff --git a/testsuite/expect/test1.74 b/testsuite/expect/test1.74 index 7ee040ebe50c2a088f10fdb4999bb119c41c29fb..9dda7f228d9d449407e7806a7b8da2753dd05f80 100755 --- a/testsuite/expect/test1.74 +++ b/testsuite/expect/test1.74 @@ -112,20 +112,17 @@ proc srun_test {exp_cnt account} { wait } } - - if {$count != $exp_cnt} { - send_user "\nFAILURE: incorrect number of jobs were ran $count != $exp_cnt\n" - set exit_code 1 - } - if {$job_id == 0} { - send_user "\nFAILURE: did not get job id\n" - return -1 - } else { + send_user "\nFAILURE: did not get job ID\n" + set exit_code 1 return $job_id } - + if {$count != $exp_cnt} { + send_user "\nFAILURE: incorrect number of tasks were run ($count != $exp_cnt)\n" + set exit_code 1 + } + return $job_id } proc add_child {parent child maxnode grpnode} { @@ -294,7 +291,8 @@ cleanup if {$exit_code == 0} { send_user "\nSUCCESS\n" +} else { + send_user "\nFAILURE\n" } - exit $exit_code