From 1c9fca4948b7bc83d8de939b5bc6cdbff7220fd3 Mon Sep 17 00:00:00 2001
From: Danny Auble <da@schedmd.com>
Date: Fri, 23 Aug 2013 10:52:51 -0700
Subject: [PATCH] CRAY- Might as well return buf now.
---
src/plugins/select/cray/select_cray.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/plugins/select/cray/select_cray.c b/src/plugins/select/cray/select_cray.c
index 4a43a724716..17a84d95f7b 100644
--- a/src/plugins/select/cray/select_cray.c
+++ b/src/plugins/select/cray/select_cray.c
@@ -860,12 +860,10 @@ extern char *select_p_select_jobinfo_sprint(select_jobinfo_t *jobinfo,
error("select/cray jobinfo_sprint: jobinfo bad");
return NULL;
}
- /* FIXME: in the future print out the header here (if needed)
- * You will need to return buf instead of NULL as well.
- */
+ /* FIXME: in the future print out the header here (if needed) */
/* snprintf(buf, size, "%s", header); */
- return NULL;
+ return buf;
}
switch (mode) {
@@ -894,12 +892,10 @@ extern char *select_p_select_jobinfo_xstrdup(select_jobinfo_t *jobinfo,
error("select/cray jobinfo_xstrdup: jobinfo bad");
return NULL;
}
- /* FIXME: in the future copy the header here (if needed)
- * You will need to return buf instead of NULL as well.
- */
+ /* FIXME: in the future copy the header here (if needed) */
/* xstrcat(buf, header); */
- return NULL;
+ return buf;
}
switch (mode) {
--
GitLab