From 0201374f8d5d6d65c63f1266d83b43d2177a2670 Mon Sep 17 00:00:00 2001
From: Morris Jette <jette@schedmd.com>
Date: Thu, 16 Nov 2017 15:24:13 -0700
Subject: [PATCH] Fix for memory leak
Coverity CID 179255
---
src/common/env.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/common/env.c b/src/common/env.c
index 7f388de5559..0bd293e16f8 100644
--- a/src/common/env.c
+++ b/src/common/env.c
@@ -268,14 +268,14 @@ int setenvf(char ***envp, const char *name, const char *fmt, ...)
va_list ap;
int size, rc;
+ if (!name)
+ return EINVAL;
+
value = xmalloc(ENV_BUFSIZE);
va_start(ap, fmt);
vsnprintf(value, ENV_BUFSIZE, fmt, ap);
va_end(ap);
- if (!name)
- return EINVAL;
-
size = strlen(name) + strlen(value) + 2;
if (size >= MAX_ENV_STRLEN) {
error("environment variable %s is too long", name);
--
GitLab