Commit f2b09a5f authored by Daniel Schreiber's avatar Daniel Schreiber

Bugfix Attribut Update

Der Updatemechanismus für die Attribute hat jetzt endlich einige Tests.
parent 6c34b578
Pipeline #33757 passed with stage
in 32 seconds
......@@ -243,7 +243,9 @@ class Resource(models.Model):
if self.reject_request(is_sp_local, local_attrib, rmt_attrib, user_type):
attrib_dict.update({
"status": "rejected"
"status": "rejected",
"vec_sp": local_attrib.vec_sp,
"vec_idp": local_attrib.vec_idp,
})
res.append({attrib_name: attrib_dict})
else:
......@@ -271,10 +273,10 @@ class Resource(models.Model):
return res
def reject_request(self, is_sp_local, local_attrib, rmt_attrib, user_type):
local_vec = VersionVector(local_attrib.vec_sp, local_attrib.vec_idp)
remote_vec = VersionVector(rmt_attrib.get("vec_sp"), rmt_attrib.get("vec_idp"))
reject_request = False
if user_type == UserType.TYPE_SYNC:
local_vec = VersionVector(local_attrib.vec_sp, local_attrib.vec_idp)
remote_vec = VersionVector(rmt_attrib.get("vec_sp"), rmt_attrib.get("vec_idp"))
if local_vec.concurrent_to(remote_vec) or remote_vec.happened_before(local_vec):
# As this is represents a conflict situation - depending on prioritization -
# we might have to reject this request in order to keep ours dominant
......@@ -285,7 +287,19 @@ class Resource(models.Model):
if local_attrib.prio == PriorityRole.ROLE_IDP and not is_sp_local:
# We are IdP and this attribute prioritizes IdP
reject_request = True
# else: Local changes only require incrementing our local component
# jetzt müssen wir noch testen, dass die andere Seite nicht fälschlicherweise unseren Teil der Vektoruhr updatet
if is_sp_local:
if remote_vec.sp and remote_vec.sp > local_vec.sp:
reject_request = True
else:
if remote_vec.idp and remote_vec.idp < local_vec.idp:
reject_request = True
else: # Local changes only require incrementing our local component
if remote_vec.idp and remote_vec.idp < local_vec.idp:
reject_request = True
if remote_vec.sp and remote_vec.sp < local_vec.sp:
reject_request = True
return reject_request
......
......@@ -14,7 +14,7 @@ from django.test.client import encode_multipart
from rest_framework.renderers import JSONRenderer
from rest_framework.reverse import reverse
from rest_framework.test import APITestCase
from api.models import QueueJob, Resource, ServiceProvider, TokenAuthUser, UserType
from api.models import Attribute, QueueJob, Resource, ServiceProvider, TokenAuthUser, UserType
from api.serializers import ResourceSerializer
......@@ -225,6 +225,202 @@ class ResourceGetTest(APITestCase):
self.assertEqual(r.status_code, 200)
class ResourceUpdateTest(APITestCase):
def setUp(self):
self.sp = ServiceProvider.objects.create(
name="TestService",
expiry_date=timezone.now(),
realm="a.edu"
)
self.sp_user = TokenAuthUser.objects.create_superuser(
username='sp',
email='foo@bar.com',
password='sp',
user_type=UserType.TYPE_SP,
api_url="http://api.a.edu:7000/",
realm="a.edu",
sp=self.sp,
)
self.idp_user = TokenAuthUser.objects.create_superuser(
username='idp',
email='foo@bar.com',
password='idp',
user_type=UserType.TYPE_IDP,
api_url="http://api.b.edu:7000/",
realm="b.edu",
)
self.sync_user = TokenAuthUser.objects.create_superuser(
username='sync',
email='foo@bar.com',
password='idp',
user_type=UserType.TYPE_SYNC,
api_url="http://api.b.edu:7000/",
realm="b.edu",
)
self.r = Resource(sp=self.sp, expiry_date=timezone.now(), deletion_date=timezone.now(), setup_token="1234", eppn="foo@b.edu")
self.r.full_clean()
self.r.save()
self.attr1 = Attribute(name='test', value='foo', vec_sp=3, vec_idp=1, resource=self.r)
self.attr1.full_clean()
self.attr1.save()
self.attr2 = Attribute(name='other', value='bar', vec_sp=5, vec_idp=2, resource=self.r)
self.attr2.full_clean()
self.attr2.save()
def test_get(self):
self.client.force_authenticate(self.sp_user)
r = self.client.get(reverse('api:resource_list'))
self.maxDiff=None
self.assertEqual(r.status_code, 200)
self.assertEqual(r.json(),[{
'uuid': str(self.r.uuid),
'added': self.r.added.astimezone(timezone.get_default_timezone()).isoformat(),
'updated': self.r.updated.astimezone(timezone.get_default_timezone()).isoformat(),
'deletion_date': self.r.deletion_date.astimezone(timezone.get_default_timezone()).isoformat(),
'expiry_date': self.r.expiry_date.astimezone(timezone.get_default_timezone()).isoformat(),
'eppn': 'foo@b.edu',
'realm_idp': 'b.edu',
'setup_token': '1234',
'sp': str(self.sp.uuid),
'sp_primary_key': '',
'attributes': [
{
'name': 'test',
'value': 'foo',
'default_value': '',
'vec_sp': 3,
'vec_idp': 1
},
{
'name': 'other',
'value': 'bar',
'default_value': '',
'vec_sp': 5,
'vec_idp': 2
},
]
}])
def _run_test_update(self, vec_sp, vec_idp):
self._run_test_update_with_result(vec_sp, vec_idp, 200, vec_sp, vec_idp, 'updated')
def _run_test_update_with_result(self, vec_sp, vec_idp, expected_status_code, expected_vec_sp, expected_vec_idp, expected_status):
data = [
{
'name': 'other',
'value': 'bar2',
'default_value': '',
'vec_sp': vec_sp,
'vec_idp': vec_idp
},
]
url = reverse("api:resource_attributes", args=(self.r.pk,))
res = self.client.put(url, data, format='json')
self.assertEqual(res.status_code, expected_status_code)
result_data = res.json()
result_dict = result_data[0]['other']
self.assertEqual(result_dict, {
'status': expected_status,
'vec_sp': expected_vec_sp,
'vec_idp': expected_vec_idp,
})
attr = Attribute.objects.get(pk=self.attr2.pk)
self.assertEqual({
'vec_sp': attr.vec_sp,
'vec_idp': attr.vec_idp,
}, {
'vec_sp': expected_vec_sp,
'vec_idp': expected_vec_idp,
})
if vec_sp == expected_vec_sp and vec_idp == expected_vec_idp:
self.assertEqual(attr.value, 'bar2')
else:
self.assertEqual(attr.value, 'bar')
def test_update_ok_as_sp(self):
self.assertEqual(self.sp.is_local, True)
self.client.force_authenticate(self.sp_user)
self._run_test_update(6, 2)
def test_update_conflict_as_sp(self):
"""
Dieses Update muss fehlschlagen, weil es eine Nebenläufigkeit der Vektoruhren gibt.
"""
self.assertEqual(self.sp.is_local, True)
self.client.force_authenticate(self.sp_user)
self._run_test_update_with_result(6, 1, 200, 5, 2, 'rejected')
def test_update_too_old_as_sp(self):
"""
Dieses Update muss fehlschlagen, weil der SP Nutzer auf der SP Instanz
versucht, einen Wert zu aktualisieren, obwohl der mitgeschickte vec_sp
Zähler zu alt ist
"""
self.assertEqual(self.sp.is_local, True)
self.client.force_authenticate(self.sp_user)
self._run_test_update_with_result(4, 2, 200, 5, 2, 'rejected')
@override_settings(SERVER_REALM="b.edu")
def test_update_ok_as_idp(self):
self.assertEqual(self.sp.is_local, False)
self.client.force_authenticate(self.idp_user)
self._run_test_update(5, 3)
@override_settings(SERVER_REALM="b.edu")
def test_conflict_as_idp(self):
"""
Dieses Update muss fehlschlagen, weil es eine Nebenläufigkeit der Vektoruhren gibt.
"""
self.assertEqual(self.sp.is_local, False)
self.client.force_authenticate(self.idp_user)
self._run_test_update_with_result(4, 3, 200, 5, 2, 'rejected')
@override_settings(SERVER_REALM="b.edu")
def test_too_old_as_idp(self):
"""
Dieses Update muss fehlschlagen, weil der IDP Nutzer auf der IDP Instanz
versucht, einen Wert zu aktualisieren, obwohl der mitgeschickte vec_idp
Zähler zu alt ist
"""
self.assertEqual(self.sp.is_local, False)
self.client.force_authenticate(self.idp_user)
self._run_test_update_with_result(5, 1, 200, 5, 2, 'rejected')
@override_settings(SERVER_REALM="b.edu")
def test_ok_sync_from_sp_side(self):
# Hier testen wir, ob die Vektoruhr richtig gesetzt wird, wenn ein sync
# update vin der Seite des SPs beim IdP aufgerufen wird, also der SP ein
# Attribut geändert hat
self.assertEqual(self.sp.is_local, False)
self.client.force_authenticate(self.sync_user)
self._run_test_update(6, 2)
@override_settings(SERVER_REALM="b.edu")
def test_conflict_from_sp_side(self):
self.assertEqual(self.sp.is_local, False)
self.client.force_authenticate(self.sync_user)
self._run_test_update_with_result(6, 1, 200, 5, 2, 'rejected')
def test_ok_sync_from_idp_side(self):
"""
hier testen wir, ob die Vektoruhr richtig gesetzt wird, wenn ein sync
update von der Seite des IdPs beim SP aufgerufen wird, also der IdP
ein Attribut geändert hat und dass es beim SP richtig aktualisiert wird
"""
self.assertEqual(self.sp.is_local, True)
self.client.force_authenticate(self.sync_user)
self._run_test_update(5, 3)
def test_conflict_from_idp_side(self):
"""
Das muss fehlschlagen, weil es hier eine Nebenläufigkeit der Vektoruhren
gibt.
"""
self.assertEqual(self.sp.is_local, True)
self.client.force_authenticate(self.sync_user)
self._run_test_update_with_result(4, 3, 200, 5, 2, 'rejected')
class AttributesTest(APITestCase):
def setUp(self):
self.local_sp = ServiceProvider.objects.create(
......
......@@ -24,7 +24,7 @@ class VectorClock(object):
return found_one
else:
raise NotImplementedError
raise NotImplementedError # pragma: no cover
def concurrent_to(self, other):
if isinstance(other, VectorClock) and len(self.comp) == len(self.comp):
......@@ -33,7 +33,7 @@ class VectorClock(object):
return False
else:
raise NotImplementedError
raise NotImplementedError # pragma: no cover
def merge(self, other): # Side effect func
if isinstance(other, VectorClock) and len(self.comp) == len(self.comp):
......@@ -48,7 +48,7 @@ class VectorClock(object):
return self.comp
else:
raise NotImplementedError
raise NotImplementedError # pragma: no cover
def __str__(self):
return str(self.comp)
......@@ -62,4 +62,11 @@ class VersionVector(VectorClock):
Since the only difference relies in how VV's are updated,
no implementation changes are necessary at this place.
"""
pass
@property
def sp(self):
return self.comp[0]
@property
def idp(self):
return self.comp[1]
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment